Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add rudimentary tests for ioreg #128
@bharrisau @farcaller any thoughts on the above? As I said, my weak opinion is that we should just keep things simple (yet still quite readable, IMHO). However, if others feel strongly about using Shiny/Hamcrest I'm willing to go that route.
Either way, I would like to start clearing out my patch queue and move on to other things.
It may be reasonable to convert hamcrest's
I'm not enforcing both libs, but my two points are:
I'll approve this one PR no matter what you do use for tests, but let's get into ML to discuss if we're going to use shiny/hamcrest everywhere until I started doing that on my own. And if we end up using the libs, the code will be refactored.
PS: expect some latency in my responses, out on vacation