This repository was archived by the owner on Jul 6, 2019. It is now read-only.
ioreg: write-only register fixes #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bharrisau @dpc how's this look? |
bgamari
force-pushed
the
ioreg-write-only
branch
from
d98e706 to
296d34a
Compare
Contributor
|
Wish you didn't lump unrelated build fixes in though. |
Contributor
Author
|
@bharrisau this was a mistake that you'll find has now been fixed. |
Contributor
|
Yeah, I just remembered that the emails don't include changes. I'll be on a |
Contributor
|
Actually, phone review is OK. |
Contributor
Author
|
@bharrisau @farcaller I suspect bors is asleep. Perhaps we should just do things the old fashioned way for now? |
Contributor
|
As long as the travis build passes it should be fine. One issue is that all the PRs need to be rebuilt in Travis after master is updated. |
bgamari
added a commit
that referenced
this pull request
Aug 28, 2014
ioreg: write-only register fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #139, #140 and #141.