New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioreg: write-only register fixes #145

Merged
merged 2 commits into from Aug 28, 2014

Conversation

Projects
None yet
3 participants
@bgamari
Contributor

bgamari commented Aug 28, 2014

This closes #139, #140 and #141.

@bgamari

This comment has been minimized.

Contributor

bgamari commented Aug 28, 2014

@bharrisau @dpc how's this look?

@bgamari bgamari force-pushed the bgamari:ioreg-write-only branch from d98e706 to 296d34a Aug 28, 2014

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 28, 2014

Wish you didn't lump unrelated build fixes in though.

@bgamari

This comment has been minimized.

Contributor

bgamari commented Aug 28, 2014

@bharrisau this was a mistake that you'll find has now been fixed.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 28, 2014

Yeah, I just remembered that the emails don't include changes. I'll be on a
PC in a little bit.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 28, 2014

Actually, phone review is OK.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented on 296d34a Aug 28, 2014

r+

@bgamari

This comment has been minimized.

Contributor

bgamari commented Aug 28, 2014

@bharrisau @farcaller I suspect bors is asleep. Perhaps we should just do things the old fashioned way for now?

@bgamari bgamari added ready and removed in progress labels Aug 28, 2014

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 28, 2014

As long as the travis build passes it should be fine. One issue is that all the PRs need to be rebuilt in Travis after master is updated.

bgamari added a commit that referenced this pull request Aug 28, 2014

Merge pull request #145 from bgamari/ioreg-write-only
ioreg: write-only register fixes

@bgamari bgamari merged commit e9d9631 into hackndev:master Aug 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bgamari bgamari deleted the bgamari:ioreg-write-only branch Aug 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment