New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export zinc::std for now #150

Merged
merged 1 commit into from Aug 28, 2014

Conversation

Projects
None yet
5 participants
@bgamari
Contributor

bgamari commented Aug 28, 2014

As demonstrated in #146 this is sometimes useful even outside of the
zinc crate.

Export zinc::std for now
As demonstrated in #146 this is sometimes useful even outside of the
`zinc` crate.

@bgamari bgamari added ready and removed in progress labels Aug 28, 2014

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 28, 2014

I'm sure this will bite us at some point. Don't really mind one way or the other though.

@dpc

This comment has been minimized.

Contributor

dpc commented Aug 28, 2014

Why is ioregs referencing std::? I've errors about std::option::Option, but couldn't it just use core::option::Option?

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Aug 28, 2014

The #[deriving] macro references std, and we can't do much more at the moment than re-export from core. I think there is an issue on the rust repo for this.

@farcaller

This comment has been minimized.

farcaller commented on 4602ccb Aug 28, 2014

r+

This comment has been minimized.

Owner

bgamari replied Aug 28, 2014

@hacknbot: merge

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 4602ccb Aug 28, 2014

saw approval from farcaller
at bgamari@4602ccb

This comment has been minimized.

Contributor

hacknbot replied Aug 28, 2014

merging bgamari/zinc/master = 4602ccb into auto

This comment has been minimized.

Contributor

hacknbot replied Aug 28, 2014

bgamari/zinc/master = 4602ccb merged ok, testing candidate = 402b235

This comment has been minimized.

Contributor

hacknbot replied Aug 28, 2014

This comment has been minimized.

Contributor

hacknbot replied Aug 28, 2014

fast-forwarding master to auto = 402b235

hacknbot added a commit that referenced this pull request Aug 28, 2014

Merge pull request #150 from bgamari/master
Export zinc::std for now

Reviewed-by: farcaller
@farcaller

This comment has been minimized.

Member

farcaller commented Aug 28, 2014

@bgamari ask bors to merge it with @hacknbot: merge.

@bgamari

This comment has been minimized.

Contributor

bgamari commented Aug 28, 2014

@hacknbot: merge

@bgamari

This comment has been minimized.

Contributor

bgamari commented Aug 28, 2014

@farcaller I'm pretty sure @hacknbot hates me.

@farcaller

This comment has been minimized.

Member

farcaller commented Aug 28, 2014

@hacknbot: merge

@hacknbot hacknbot merged commit 4602ccb into hackndev:master Aug 28, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details
@farcaller

This comment has been minimized.

Member

farcaller commented Aug 28, 2014

Mhmph. Putting aside some time on the weekend to hack on it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment