Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix warnings (Copy Impl and Shadowed lifetime) #263
Conversation
0xc0170
added some commits
Dec 15, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
0xc0170
Dec 26, 2014
Contributor
I can look at the other warnings, deprecated like Decodable, Encodable.
|
I can look at the other warnings, deprecated like Decodable, Encodable. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bgamari
Dec 26, 2014
Contributor
Martin Kojtal notifications@github.com writes:
I can look at the other warnings, deprecated like Decodable, Encodable.
Thanks Martin!
|
Martin Kojtal notifications@github.com writes:
|
0xc0170
added some commits
Dec 27, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
0xc0170
Dec 27, 2014
Contributor
Almost all warnings should be gone (PT missing doc still present though
Please review
Note: I remove serialization from node.rs, as I believe it does not have any use there at the moment
|
Almost all warnings should be gone (PT missing doc still present though Please review Note: I remove serialization from node.rs, as I believe it does not have any use there at the moment |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
LGTM |
0xc0170 commentedDec 26, 2014
Shadowed lifetime and copy impl, should not be any warning with the rustc from 22nd of December regarding those 2.