New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings (Copy Impl and Shadowed lifetime) #263

Merged
merged 6 commits into from Dec 27, 2014

Conversation

Projects
None yet
3 participants
@0xc0170
Contributor

0xc0170 commented Dec 26, 2014

Shadowed lifetime and copy impl, should not be any warning with the rustc from 22nd of December regarding those 2.

@0xc0170

This comment has been minimized.

Show comment
Hide comment
@0xc0170

0xc0170 Dec 26, 2014

Contributor

I can look at the other warnings, deprecated like Decodable, Encodable.

Contributor

0xc0170 commented Dec 26, 2014

I can look at the other warnings, deprecated like Decodable, Encodable.

@bgamari

This comment has been minimized.

Show comment
Hide comment
@bgamari

bgamari Dec 26, 2014

Contributor

Martin Kojtal notifications@github.com writes:

I can look at the other warnings, deprecated like Decodable, Encodable.

Thanks Martin!

Contributor

bgamari commented Dec 26, 2014

Martin Kojtal notifications@github.com writes:

I can look at the other warnings, deprecated like Decodable, Encodable.

Thanks Martin!

@0xc0170

This comment has been minimized.

Show comment
Hide comment
@0xc0170

0xc0170 Dec 27, 2014

Contributor

Almost all warnings should be gone (PT missing doc still present though 😆) .

Please review

Note: I remove serialization from node.rs, as I believe it does not have any use there at the moment

Contributor

0xc0170 commented Dec 27, 2014

Almost all warnings should be gone (PT missing doc still present though 😆) .

Please review

Note: I remove serialization from node.rs, as I believe it does not have any use there at the moment

@farcaller

This comment has been minimized.

Show comment
Hide comment
@farcaller

farcaller Dec 27, 2014

Member

LGTM

Member

farcaller commented Dec 27, 2014

LGTM

farcaller added a commit that referenced this pull request Dec 27, 2014

Merge pull request #263 from 0xc0170/fix_warnings
Fix warnings (Copy Impl and Shadowed lifetime)

@farcaller farcaller merged commit 9fab346 into hackndev:master Dec 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@0xc0170 0xc0170 deleted the 0xc0170:fix_warnings branch Dec 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment