New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A hack to make the code compile again #43

Merged
merged 2 commits into from May 31, 2014

Conversation

Projects
None yet
2 participants
@farcaller
Member

farcaller commented May 30, 2014

Rustc forcefully exports stack_exhausted and eh_personality, resulting
in symbols being defined twice. We counter this by stripping the
symbols from all object files being produced.

A hack to make the code compile again
Rustc forcefully exports stack_exhausted and eh_personality, resulting
in symbols being defined twice. We counter this by stripping the
symbols from all object files being produced.

@farcaller farcaller referenced this pull request May 30, 2014

Closed

Simplify compile process #41

@farcaller farcaller closed this May 30, 2014

@farcaller farcaller deleted the farcaller:fix-missing-lang-items branch May 30, 2014

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented May 31, 2014

You could try the following linker flag?

--allow-multiple-definition
-z muldefs
Normally when a symbol is defined multiple times, the linker will report a fatal error. These options allow multiple definitions and the first definition will be used

@farcaller farcaller restored the farcaller:fix-missing-lang-items branch May 31, 2014

@farcaller farcaller reopened this May 31, 2014

@farcaller

This comment has been minimized.

Member

farcaller commented May 31, 2014

--allow-multiple-definition

This one is a bit too permissive.

farcaller added a commit that referenced this pull request May 31, 2014

Merge pull request #43 from farcaller/fix-missing-lang-items
A hack to make the code compile again

@farcaller farcaller merged commit 0d67094 into hackndev:master May 31, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bharrisau

This comment has been minimized.

Contributor

bharrisau commented May 31, 2014

Probably safer sticking with the strip pass than telling the linker that multiple-defs are ok. This is the first run of the stats submission, so have to see how it works.

@farcaller farcaller deleted the farcaller:fix-missing-lang-items branch Jun 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment