Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upA hack to make the code compile again #43
Conversation
farcaller
closed this
May 30, 2014
farcaller
deleted the
farcaller:fix-missing-lang-items
branch
May 30, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bharrisau
May 31, 2014
Contributor
You could try the following linker flag?
--allow-multiple-definition
-z muldefs
Normally when a symbol is defined multiple times, the linker will report a fatal error. These options allow multiple definitions and the first definition will be used
|
You could try the following linker flag?
|
farcaller
restored the
farcaller:fix-missing-lang-items
branch
May 31, 2014
farcaller
reopened this
May 31, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This one is a bit too permissive. |
added a commit
that referenced
this pull request
May 31, 2014
farcaller
merged commit 0d67094
into
hackndev:master
May 31, 2014
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bharrisau
May 31, 2014
Contributor
Probably safer sticking with the strip pass than telling the linker that multiple-defs are ok. This is the first run of the stats submission, so have to see how it works.
|
Probably safer sticking with the strip pass than telling the linker that multiple-defs are ok. This is the first run of the stats submission, so have to see how it works. |
farcaller
deleted the
farcaller:fix-missing-lang-items
branch
Jun 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
farcaller commentedMay 30, 2014
Rustc forcefully exports stack_exhausted and eh_personality, resulting
in symbols being defined twice. We counter this by stripping the
symbols from all object files being produced.