New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detached GPIO from GPIOConf #57

Merged
merged 2 commits into from Jun 8, 2014

Conversation

Projects
None yet
2 participants
@farcaller
Member

farcaller commented Jun 2, 2014

This PR decouples GPIO from GPIOConf, allowing to add more business logic into GPIO (ISR callbacks).

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jun 2, 2014

Can we leave the inlining to the compiler instead of annotating it everywhere? I haven't actually checked how good it is at inlining.

@farcaller

This comment has been minimized.

Member

farcaller commented Jun 3, 2014

Ok, done. I haven't actually checked that one as well, this is just a place where I'd use inline in C++ :)

@farcaller

This comment has been minimized.

Member

farcaller commented Jun 8, 2014

r=me

@farcaller

This comment has been minimized.

Member

farcaller commented Jun 8, 2014

@farcaller: merge

@farcaller

This comment has been minimized.

Member

farcaller commented on 246e4c9 Jun 8, 2014

Merge sha 89f6684 is stale.

This comment has been minimized.

Member

farcaller replied Jun 8, 2014

merging farcaller/zinc/refactor-gpio = 246e4c9 into auto

This comment has been minimized.

Member

farcaller replied Jun 8, 2014

farcaller/zinc/refactor-gpio = 246e4c9 merged ok, testing candidate = cd092b7

This comment has been minimized.

Member

farcaller replied Jun 8, 2014

fast-forwarding master to auto = cd092b7

farcaller added a commit that referenced this pull request Jun 8, 2014

Merge pull request #57 from farcaller/refactor-gpio
Detached GPIO from GPIOConf

Reviewed-by:

@farcaller farcaller merged commit 246e4c9 into hackndev:master Jun 8, 2014

1 of 2 checks passed

default running tests for candidate cd092b79f529fb32b8958ea2b5031a71d4237ccc
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@farcaller farcaller deleted the farcaller:refactor-gpio branch Jun 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment