New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added coverage support for master branch #70

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@farcaller
Member

farcaller commented Jun 15, 2014

No description provided.

@farcaller

This comment has been minimized.

Owner

farcaller commented on 6f135b0 Jun 15, 2014

r=me

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 6f135b0 Jun 15, 2014

saw approval from farcaller, me
at farcaller@6f135b0

This comment has been minimized.

Contributor

hacknbot replied Jun 15, 2014

merging farcaller/zinc/coverage = 6f135b0 into auto

This comment has been minimized.

Contributor

hacknbot replied Jun 15, 2014

farcaller/zinc/coverage = 6f135b0 merged ok, testing candidate = 6190b00

This comment has been minimized.

Contributor

hacknbot replied Jun 15, 2014

hacknbot added a commit that referenced this pull request Jun 15, 2014

Merge pull request #70 from farcaller/coverage
Added coverage support for master branch

Reviewed-by: farcaller,me
@errordeveloper

This comment has been minimized.

errordeveloper commented on .travis.yml in 9be8417 Jul 2, 2014

No longer needed since hackndev#75.

@errordeveloper

This comment has been minimized.

errordeveloper commented on support/rake.rb in 9be8417 Jul 2, 2014

perhaps better to look for it the shell's path instead?

This comment has been minimized.

Owner

farcaller replied Jul 2, 2014

It's surely not in shell path. It's kind of tricky to compile, so I seed travis with static binary.

This comment has been minimized.

errordeveloper replied Jul 2, 2014

I mean, on Travis you could export PATH="${PATH}:."

This comment has been minimized.

errordeveloper replied Jul 2, 2014

So you could then generalise the build script.

@errordeveloper

This comment has been minimized.

Member

errordeveloper commented Jul 2, 2014

👍

@farcaller

This comment has been minimized.

Member

farcaller commented Jul 3, 2014

Ok, will do that when we see some progress on rust-lang/rust#14930. Thanks for your comments.

@farcaller farcaller closed this Jun 2, 2015

@bharrisau bharrisau removed the in progress label Jun 2, 2015

@farcaller farcaller deleted the farcaller:coverage branch Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment