Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating demo code to use PT #71

Merged
merged 21 commits into from Jun 25, 2014

Conversation

Projects
None yet
2 participants
@farcaller
Copy link
Member

commented Jun 15, 2014

Expanding PT to support app_empty and app_blink demos.

@farcaller farcaller self-assigned this Jun 15, 2014

farcaller added some commits Jun 15, 2014

Recovering from broken .git tree. This includes the following commits:
 * 3a40290 app_blink is now buildable with PT.
 * 4ed74c7 Removed lifetime arg from lpc17xx::GPIO.
 * 0f60ef3 Temporary extracted pinconf to deal with lifetimes.
 * 831adb6 Generated args struct now uses correct lifetimes for refs.
 * d92eb08 Added os/single_task/args builder (a bit broken).
 * 070482f Using DUMMY_SP where possible.
 * 594a145 Parser now returns gc-wrapped platformtree.
 * 0a8cbd4 Fixed GPIOConf typo in generated gpio node.
 * 1d2f851 Tests are now always being built with `-g`.
 * e013567 Extracted TokenString to builder.
 * 51fa0c7 Added platformtee_verbose! macro to dump generated code.
 * 1a8cdb4 Cleaned up app_empty demo code.
 * 35de740 Very basic gpio subnode implementation for lpc17xx.
 * 6c75500 Basic timer subnode implementation for lpc17xx.
 * 3197ce6 Refactored test helpers to use pprust for source rendering.
 * 4267646 Starting refactoring work on app_blink.
 * 2b40597 Cleaned up app_empty demo, this one is done.
 * 7fe9f17 Debug build breaks IDA and Hopper, huh.
 * ef9a9af build_os builds a correct call to loop function now.
 * e64807b Compilation fixes for recent rustc version.
@farcaller

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2014

HFS+ decided to put some Chrome cache files in the same inodes as my .git 😱

The last commit includes app_blink fully ported to PT, tests green. @bharrisau, please take a look and r+ if there are no pressing issues. The code is a bit messy and I will clean it up in the next PR, after I re-install my mac.

Short summary of included changes:

  • app crates are staticlibs once again, all support code is provided by platformtree!() macro;
  • app_bink and app_empty ported over to PT; support for stm32 is removed for now;
  • quite a mess in platformtree crate to add support for above; no tests for expected failure cases yet;
  • builder will now emit mod pt {} for its internally used structs;
  • a few code cleanups & updates for recent rustc;
  • lpc17xx GPIO interface lost its lifetime attribute; that code will be eventually refactored anyway;
  • test builds now always use -g

Looking for comments on demo apps code.

@farcaller

This comment has been minimized.

Copy link
Owner Author

commented on db3d4d0 Jun 25, 2014

verified working on the hardware, closing this and moving on.

This comment has been minimized.

Copy link
Owner Author

replied Jun 25, 2014

r+

@hacknbot

This comment has been minimized.

Copy link
Contributor

commented on db3d4d0 Jun 25, 2014

saw approval from farcaller
at farcaller@db3d4d0

This comment has been minimized.

Copy link
Contributor

replied Jun 25, 2014

merging farcaller/zinc/new-demos = db3d4d0 into auto

This comment has been minimized.

Copy link
Contributor

replied Jun 25, 2014

farcaller/zinc/new-demos = db3d4d0 merged ok, testing candidate = 2abb314

This comment has been minimized.

Copy link
Contributor

replied Jun 25, 2014

This comment has been minimized.

Copy link
Contributor

replied Jun 25, 2014

fast-forwarding master to auto = 2abb314

hacknbot added a commit that referenced this pull request Jun 25, 2014

Merge pull request #71 from farcaller/new-demos
Updating demo code to use PT

Reviewed-by: farcaller

@hacknbot hacknbot merged commit db3d4d0 into hackndev:master Jun 25, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details

@farcaller farcaller deleted the farcaller:new-demos branch Jun 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.