New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute deprication warnings #92

Merged
merged 3 commits into from Jul 7, 2014

Conversation

Projects
None yet
3 participants
@errordeveloper
Member

errordeveloper commented Jul 6, 2014

  1. warning: phase(syntax) is a deprecated synonym for phase(plugin)
  2. warning: the #[crate_id] attribute is deprecated for the #[crate_name] attribute

errordeveloper added some commits Jul 6, 2014

Fix attribute deprication warning -
src/main.rs:48:14: 48:42 warning: phase(syntax) is a deprecated synonym for phase(plugin)

@errordeveloper errordeveloper changed the title from Fix attribute deprication warning to Fix attribute deprication warnings Jul 7, 2014

@errordeveloper

This comment has been minimized.

Member

errordeveloper commented Jul 7, 2014

Looks like the up-to-date example apps don't use crate_id, so I removed it from others...

@farcaller

This comment has been minimized.

farcaller commented on 45937ab Jul 7, 2014

r+

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 45937ab Jul 7, 2014

saw approval from farcaller
at errordeveloper@45937ab

This comment has been minimized.

Contributor

hacknbot replied Jul 7, 2014

merging errordeveloper/zinc/fix_silly_warning = 45937ab into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 7, 2014

errordeveloper/zinc/fix_silly_warning = 45937ab merged ok, testing candidate = bc57b0c

This comment has been minimized.

Contributor

hacknbot replied Jul 7, 2014

This comment has been minimized.

Contributor

hacknbot replied Jul 7, 2014

fast-forwarding master to auto = bc57b0c

hacknbot added a commit that referenced this pull request Jul 7, 2014

Merge pull request #92 from errordeveloper/fix_silly_warning
Fix attribute deprication warnings

Reviewed-by: farcaller

@hacknbot hacknbot merged commit 45937ab into hackndev:master Jul 7, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details

@errordeveloper errordeveloper deleted the errordeveloper:fix_silly_warning branch Jul 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment