New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for stm32f4 #97

Merged
merged 1 commit into from Jul 14, 2014

Conversation

Projects
None yet
4 participants
@errordeveloper
Member

errordeveloper commented Jul 13, 2014

This is to close #81 and hopefully #66.

#[allow(unused_variable)]
#[allow(dead_code)]
pub unsafe fn main() {
use zinc::hal::timer::Timer;

This comment has been minimized.

@farcaller

farcaller Jul 13, 2014

Member

Can you please fix the indentation?

This comment has been minimized.

@errordeveloper

errordeveloper Jul 13, 2014

Member

Ah... that's @ah-'s fault ;) Will do in a bit.

@errordeveloper

This comment has been minimized.

Member

errordeveloper commented Jul 13, 2014

Ok, should be ready now.

@bharrisau

This comment has been minimized.

Contributor

bharrisau commented Jul 14, 2014

LGTM, but I'll leave it for @farcaller. Subsequent PRs should move to platform tree macro, and also make sure all the public methods have doc comments (I'll be enabling the lint for that next time I get a chance).

@farcaller

This comment has been minimized.

farcaller commented on 9bb73ec Jul 14, 2014

r+

@hacknbot

This comment has been minimized.

Contributor

hacknbot commented on 9bb73ec Jul 14, 2014

saw approval from farcaller
at errordeveloper@9bb73ec

This comment has been minimized.

Contributor

hacknbot replied Jul 14, 2014

merging errordeveloper/zinc/fix_pr_81 = 9bb73ec into auto

This comment has been minimized.

Contributor

hacknbot replied Jul 14, 2014

errordeveloper/zinc/fix_pr_81 = 9bb73ec merged ok, testing candidate = 52ff543

This comment has been minimized.

Contributor

hacknbot replied Jul 14, 2014

This comment has been minimized.

Contributor

hacknbot replied Jul 14, 2014

fast-forwarding master to auto = 52ff543

hacknbot added a commit that referenced this pull request Jul 14, 2014

Merge pull request #97 from errordeveloper/fix_pr_81
Fixes for stm32f4

Reviewed-by: farcaller

@hacknbot hacknbot merged commit 9bb73ec into hackndev:master Jul 14, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed
Details

@errordeveloper errordeveloper deleted the errordeveloper:fix_pr_81 branch Jul 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment