Skip to content

HCK-3947 Fix extensions RE for top-level schema components #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

HCK-3947 Fix extensions RE for top-level schema components #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fae4d72
add extensions for array type
taras-dubyk Sep 6, 2023
42a3650
handle extensions for components schema root items
taras-dubyk Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions properties_pane/field_level/fieldLevelConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1804,6 +1804,35 @@ making sure that you maintain a proper JSON format.
{
"propertyKeyword": "subtype",
"hidden": true
},
{
"propertyName": "extensions",
"propertyType": "group",
"propertyKeyword": "scopesExtensions",
"shouldValidate": true,
"propertyTooltip": "",
"structure": [
{
"propertyName": "pattern",
"propertyKeyword": "extensionPattern",
"shouldValidate": true,
"propertyType": "text",
"regex":"^x-"
},
{
"propertyName": "value",
"propertyKeyword": "extensionValue",
"propertyValidate": false,
"propertyTooltip": "Popup for multi-line text entry",
"propertyType": "details",
"template": "textarea",
"markdown": false
}
],
"dependency": {
"key": "subtype",
"value": "schema"
}
}
],
"object": [
Expand Down
3 changes: 2 additions & 1 deletion reverse_engineering/helpers/dataHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,8 @@ const handleDefinitionSchemaProps = (schema, fieldOrder) => {

const fixedSchema = convertFormatToMode(setMissedType(schema));
const schemaWithAdditionalPropertiesData = handleAdditionalProperties(fixedSchema);
const reorderedSchema = commonHelper.reorderFields(schemaWithAdditionalPropertiesData, fieldOrder);
const schemaWithExtensions = handleSchemaExtensions(schemaWithAdditionalPropertiesData);
const reorderedSchema = commonHelper.reorderFields(schemaWithExtensions, fieldOrder);
const schemaWithHandledProperties = Object.keys(reorderedSchema).reduce((accumulator, property) => {
if (property === 'example') {
property = 'sample';
Expand Down