Skip to content

HCK-13023: if no key in composite PK/UK then default to empty array #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

HCK-13023: if no key in composite PK/UK then default to empty array #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions forward_engineering/alterScript/alterScriptHelpers/entityHelpers/primaryKeyHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const wasCompositePkChangedInTransitionFromCompositeToRegular = collection => {
* @type {AlterCollectionRoleCompModPKDto[]}
* */
const oldPrimaryKeys = pkDto.old || [];
const idsOfColumns = oldPrimaryKeys.flatMap(pk => pk.compositePrimaryKey.map(dto => dto.keyId));
const idsOfColumns = oldPrimaryKeys.flatMap(pk => pk.compositePrimaryKey?.map(dto => dto.keyId) || []);
if (idsOfColumns.length !== amountOfColumnsInRegularPk) {
// We return false, because it wouldn't count as transition between regular PK and composite PK
// if composite PK did not constraint exactly 1 column
Expand Down Expand Up @@ -120,7 +120,7 @@ const wasCompositePkChangedInTransitionFromRegularToComposite = collection => {
* @type {AlterCollectionRoleCompModPKDto[]}
* */
const newPrimaryKeys = pkDto.new || [];
const idsOfColumns = newPrimaryKeys.flatMap(pk => pk.compositePrimaryKey.map(dto => dto.keyId));
const idsOfColumns = newPrimaryKeys.flatMap(pk => pk.compositePrimaryKey?.map(dto => dto.keyId) || []);
if (idsOfColumns.length !== amountOfColumnsInRegularPk) {
// We return false, because it wouldn't count as transition between regular PK and composite PK
// if composite PK does not constraint exactly 1 column
Expand Down
4 changes: 2 additions & 2 deletions forward_engineering/alterScript/alterScriptHelpers/entityHelpers/uniqueKeyHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const wasCompositeUniqueKeyChangedInTransitionFromCompositeToRegular = collectio
* @type {AlterCollectionRoleCompModUniqueKeyDto[]}
* */
const oldUniqueKeys = uniqueDto.old || [];
const idsOfColumns = oldUniqueKeys.flatMap(unique => unique.compositeUniqueKey.map(dto => dto.keyId));
const idsOfColumns = oldUniqueKeys.flatMap(unique => unique.compositeUniqueKey?.map(dto => dto.keyId) || []);
if (idsOfColumns.length !== amountOfColumnsInRegularUniqueKey) {
// We return false, because it wouldn't count as transition between regular UniqueKey and composite UniqueKey
// if composite UniqueKey did not constraint exactly 1 column
Expand Down Expand Up @@ -124,7 +124,7 @@ const wasCompositeUniqueKeyChangedInTransitionFromRegularToComposite = collectio
* @type {AlterCollectionRoleCompModUniqueKeyDto[]}
* */
const newUniqueKeys = uniqueDto.new || [];
const idsOfColumns = newUniqueKeys.flatMap(unique => unique.compositeUniqueKey.map(dto => dto.keyId));
const idsOfColumns = newUniqueKeys.flatMap(unique => unique.compositeUniqueKey?.map(dto => dto.keyId) || []);
if (idsOfColumns.length !== amountOfColumnsInRegularUniqueKey) {
// We return false, because it wouldn't count as transition between regular UniqueKey and composite UniqueKey
// if composite UniqueKey does not constraint exactly 1 column
Expand Down