Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Emotion 10 code-mod #544

Closed
jaronheard opened this issue May 20, 2019 · 2 comments
Closed

Run Emotion 10 code-mod #544

jaronheard opened this issue May 20, 2019 · 2 comments
Assignees
Labels
type:platform Issues that are impact the entire Civic project

Comments

@jaronheard
Copy link
Contributor

jaronheard commented May 20, 2019

What

Run Emotion 10 code-mod on all packages. This will include enabling eslint-plugin-emotion. Details below:

Automatically: The first part can be done automatically by using eslint-plugin-emotion at https://emotion.sh/docs/eslint-plugin-emotion#emotion-10-codemods. This will make the following changes:
a. Change all react-emotion imports so that styled is imported from @emotion/styled and all the emotion exports are split into a second import.
b. Add a css call to the css prop when a template literal is used.
c. Add a jsx import and set jsx pragma

Why

First step in #526

When

Not time sensitive at the moment

@jaronheard jaronheard added this to Backlog in 2019 Front-End Team via automation May 20, 2019
@jaronheard jaronheard added the type:platform Issues that are impact the entire Civic project label May 20, 2019
@jaronheard jaronheard moved this from Backlog to 👋Ready for Dev | Prioritized in 2019 Front-End Team May 20, 2019
@kdv24 kdv24 self-assigned this May 22, 2019
@kdv24 kdv24 moved this from 👋Ready for Dev | Prioritized to In Development in 2019 Front-End Team May 22, 2019
@kdv24 kdv24 removed their assignment May 22, 2019
@kdv24 kdv24 moved this from In Development to 👋Ready for Dev | Prioritized in 2019 Front-End Team May 22, 2019
@toyotathon
Copy link
Contributor

Can I get assigned to this issue?

@jaronheard
Copy link
Contributor Author

I assigned you! But also, I added you to the the proper team so that you can assign yourself in the future. 🙌

@jaronheard jaronheard moved this from 👋Ready for Dev | Prioritized to In Development in 2019 Front-End Team May 23, 2019
toyotathon added a commit that referenced this issue Jun 10, 2019
2019 Front-End Team automation moved this from In Development to Done Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:platform Issues that are impact the entire Civic project
Projects
Development

No branches or pull requests

3 participants