Design system/horizontal bar chart #565
Conversation
There was a problem hiding this comment.
This looks really great, @bradfordjanice !
My only suggestions were minor.
| DATA: "Data", | ||
| CUSTOM: "Custom" | ||
| }; | ||
| const getKeyNames = obj => { |
There was a problem hiding this comment.
Since this is reused in BarChart, HorizontalBarChart, and will be used in other stories, extract to shared.js helper file and import rather than duplicating.
There was a problem hiding this comment.
I will also extract getKeyNames from the BarChart story and import from shared.js. (In a new branch.)
| return ( | ||
| <HorizontalBarChart | ||
| data={data} | ||
| sortOrder={sortOrder} |
There was a problem hiding this comment.
Technically, sortOrder isn't required, the component will pick a sortOrder by default. We should move it to the custom story.
A follow up issue for this is that the default sort should be changed to sort from highest value to lowest value, rather than the current sorting method.
jaronheard
moved this from 👋Ready for Review | Prioritized
to In Review
in 2019 Front-End Team
Updated the HorizontalBarChart story: organized stories, added notes, created knobs for each story.