Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove styled-components dep from component-library #624

Merged
merged 1 commit into from Jun 23, 2019

Conversation

Projects
None yet
2 participants
@iankerriganharris
Copy link
Contributor

commented Jun 23, 2019

The installed version of styled-components does not support React 16, leading to this error when installing component-library in React 16 projects:

"@hackoregon/component-library > styled-components@1.4.6" has incorrect peer dependency "react@^0.14.0 || ^15.0.0-0"

styled-components is no longer used so it should be safe to remove.

@iankerriganharris iankerriganharris requested a review from jaronheard Jun 23, 2019

@jaronheard
Copy link
Contributor

left a comment

Looks great! Go ahead and merge.

Closes #546

@iankerriganharris iankerriganharris merged commit 5656f86 into master Jun 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jaronheard jaronheard referenced this pull request Jun 26, 2019

Closed

Replace styled-components with emotion #546

2 of 2 tasks complete

@jaronheard jaronheard deleted the remove-styled-components branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.