Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT so safe eval #16

Open
ChrisCinelli opened this issue Dec 29, 2018 · 0 comments

Comments

@ChrisCinelli
Copy link

@ChrisCinelli ChrisCinelli commented Dec 29, 2018

I was looking at patriksimek/vm2#32 - The implementation in vm2 have patched a lot of vulnerabilities but there are a ton of problems because of trying to prevent all backdoors.

According to patriksimek/vm2#32 (comment) the only way to fix this class of vulnerabilities is completely disabling eval with a C++ addon. And in the best case scenario you are still vulnerable to DoD attacks.

The code of safe-eval is way too simple. #15 is a futile effort.

I just think that the name of this module is misleading. People may think (like I was) that safe-eval is reasonable secure but it is far from the truth.

In my humble opinion, safe-eval should just marked as vulnerable and the README.md should have a very noticeable disclaimer about not being safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.