From b426fc262215d44313ee15bb7f5cb1332b357a2f Mon Sep 17 00:00:00 2001
From: Javier Spagnoletti <phansys@gmail.com>
Date: Fri, 6 Apr 2018 12:51:12 -0300
Subject: [PATCH] [UserManager] Some minor improvements

---
 Manager/UserManager.php | 29 ++++++++++++++---------------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/Manager/UserManager.php b/Manager/UserManager.php
index 2919b273..1cf59838 100644
--- a/Manager/UserManager.php
+++ b/Manager/UserManager.php
@@ -2,38 +2,39 @@
 
 namespace Hackzilla\Bundle\TicketBundle\Manager;
 
-use Doctrine\ORM\EntityRepository;
+use Doctrine\Common\Persistence\ObjectRepository;
 use Hackzilla\Bundle\TicketBundle\Model\TicketInterface;
 use Hackzilla\Bundle\TicketBundle\Model\UserInterface;
 use Hackzilla\Bundle\TicketBundle\TicketRole;
-use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
+use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
 
 class UserManager implements UserManagerInterface
 {
     /**
-     * @var \Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface
+     * @var TokenStorageInterface
      */
     private $tokenStorage;
 
     /**
-     * @var \Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
+     * @var AuthorizationCheckerInterface
      */
     private $authorizationChecker;
 
     /**
-     * @var \Doctrine\ORM\EntityRepository
+     * @var ObjectRepository
      */
     private $userRepository;
 
     /**
-     * @param TokenStorage                  $tokenStorage
+     * @param TokenStorageInterface         $tokenStorage
+     * @param ObjectRepository              $userRepository
      * @param AuthorizationCheckerInterface $authorizationChecker
-     * @param EntityRepository              $userRepository
      */
     public function __construct(
-        TokenStorage $tokenStorage,
-        EntityRepository $userRepository,
+        TokenStorageInterface $tokenStorage,
+        ObjectRepository $userRepository,
         AuthorizationCheckerInterface $authorizationChecker
     ) {
         $this->tokenStorage = $tokenStorage;
@@ -66,9 +67,7 @@ public function getUserById($userId)
             return;
         }
 
-        $user = $this->userRepository->find($userId);
-
-        return $user;
+        return $this->userRepository->find($userId);
     }
 
     /**
@@ -85,8 +84,8 @@ public function hasRole(UserInterface $user, $role)
     }
 
     /**
-     * @param \Hackzilla\Bundle\TicketBundle\Model\UserInterface|string $user
-     * @param TicketInterface                                           $ticket
+     * @param UserInterface|string $user
+     * @param TicketInterface      $ticket
      */
     public function hasPermission($user, TicketInterface $ticket)
     {
@@ -95,7 +94,7 @@ public function hasPermission($user, TicketInterface $ticket)
                     TicketRole::ADMIN
                 ) && $ticket->getUserCreated() != $user->getId())
         ) {
-            throw new \Symfony\Component\HttpKernel\Exception\HttpException(403);
+            throw new AccessDeniedHttpException();
         }
     }
 }