New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip using setns if unsupported #5

Merged
merged 4 commits into from Nov 7, 2016

Conversation

Projects
None yet
2 participants
@udzura
Member

udzura commented Nov 7, 2016

glibc started to support setns(2) after glibc-2.14. see http://man7.org/linux/man-pages/man2/setns.2.html

setns(2) is not always required in creating container(we use unshare on create), so it is nice to skip using setns by glibc version they use.

@udzura udzura merged commit c29c561 into master Nov 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@udzura udzura deleted the skip-setns-usage-if-unsupported branch Nov 7, 2016

@matsumotory

This comment has been minimized.

Show comment
Hide comment
@matsumotory

matsumotory Nov 7, 2016

Member

Very quick!!

Member

matsumotory commented Nov 7, 2016

Very quick!!

@udzura

This comment has been minimized.

Show comment
Hide comment
@udzura
Member

udzura commented Nov 7, 2016

quick man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment