Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pale Moon support #4

Closed
mattatobin opened this issue Jan 7, 2015 · 8 comments
Closed

Pale Moon support #4

mattatobin opened this issue Jan 7, 2015 · 8 comments

Comments

@mattatobin
Copy link

@mattatobin mattatobin commented Jan 7, 2015

Greetings,

I am the Add-on Site Administrator and Add-ons Team Leader for the Pale Moon project. A divergent and independently developed Mozilla-based browser originally forked from Firefox. Your add-on has been reported as being incompatible with Pale Moon and upon looking into why this is it seems that this extension is technologically compatible with us but is blocked from installing due to install.rdf restrictions.

While we have allowed legacy Firefox add-ons targeted at the Firefox 24 level to install generally without modification this assumes said add-on has a minimum version requirement of 24 or below. However, your add-on has a minver of 26 so it fails to install.

If you would like to directly support the Pale Moon browser you can add a Pale Moon specific application block to your install.rdf as outlined here: http://forum.palemoon.org/viewtopic.php?f=1&t=5440

Thank you for your time and consideration.

-Matt A. Tobin

@hadalin
Copy link
Owner

@hadalin hadalin commented Jan 7, 2015

Lowered minimum version requirement to 24 :)

I don't have install.rdf file. I can make a Pale Moon branch, put whatever is needed there and release it. Just tell me what to put inside install.rdf file and anything else that's needed.

@mattatobin
Copy link
Author

@mattatobin mattatobin commented Jan 7, 2015

Changing the minimum version on AMO won't change what is in the generated install.rdf in the packaged xpi file.

What you would have to do is after you package the extension is to crack it open and edit install.rdf. This would be the simplest method without disrupting your workflow too much and without rethinking how your add-on is created.

The Add-on SDK and default tools provided simply do not take anything other than Firefox into account.

@hadalin
Copy link
Owner

@hadalin hadalin commented Jan 7, 2015

Using Add-on SDK. Command line tool does everything for you, initializing the project, packaging (making xpi), etc.

On 7. jan. 2015, at 20.58, Matt A. Tobin notifications@github.com wrote:

How are you packaging and publishing this add-on?


Reply to this email directly or view it on GitHub.

@hadalin
Copy link
Owner

@hadalin hadalin commented Jan 7, 2015

Will crack open the xpi and change what needs to be changed. Tomorrow I'm quite busy though.

On 7. jan. 2015, at 20.58, Matt A. Tobin notifications@github.com wrote:

How are you packaging and publishing this add-on?


Reply to this email directly or view it on GitHub.

@Fogest
Copy link
Contributor

@Fogest Fogest commented Jan 7, 2015

I'm confused, why isn't a pull request just submitted if this is a specific
request for a 3rd party browser?

Justin V

On Wed, Jan 7, 2015 at 4:32 PM, Primož Hadalin notifications@github.com
wrote:

Will crack open the xpi and change what needs to be changed. Tomorrow I'm
quite busy though.

On 7. jan. 2015, at 20.58, Matt A. Tobin notifications@github.com
wrote:

How are you packaging and publishing this add-on?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#4 (comment)
.

@mattatobin
Copy link
Author

@mattatobin mattatobin commented Jan 7, 2015

@Fogest Because there is NOTHING to do a pull request on. Not without significantly changing how the extension is packaged. Right now it uses the SDK command line tools which when packaging process package.json but it doesn't HAVE any thing to determin targeted applications. It just assumes Firefox and writes it out wholesale. There is nothing in package.json to add.

If I had more time I could likely devise a solution up for this add-on but I don't at this time. Modifying the install.rdf with a quick cut and paste of the Pale Moon target application block is the simplest method right now to provide multiple application support and to support Pale Moon users.

@hadalin Thanks man it is appreciated very much. Like I indicated if I get time as well I will see if there is anything I can contribute to make dealing with install.rdf generation easier if it is desired.

In the mean time thanks again :)

@Fogest
Copy link
Contributor

@Fogest Fogest commented Jan 7, 2015

Ah okay, thanks for the application.

Justin V

On Wed, Jan 7, 2015 at 5:56 PM, Matt A. Tobin notifications@github.com
wrote:

@Fogest https://github.com/Fogest Because there is NOTHING to do a pull
request on. Not without significantly changing how the extension is
packaged. Right now it uses the SDK command line tools which when packaging
process package.json but it doesn't HAVE any thing to determin targeted
applications. It just assumes Firefox and writes it out wholesale. There is
nothing in package.json to add.

If I had more time I could likely devise a solution up for this add-on but
I don't at this time. Modifying the install.rdf with a quick cut and paste
of the Pale Moon target application block is the simplest method right now
to provide multiple application support and to support Pale Moon users.


Reply to this email directly or view it on GitHub
#4 (comment)
.

@hadalin
Copy link
Owner

@hadalin hadalin commented Jan 9, 2015

@mattatobin Changed install.rdf, tested it on Pale Moon and it seems to work nicely https://github.com/hadalin/firefox-hidefedora/tree/palemoon/dist

@hadalin hadalin closed this Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants