-
Notifications
You must be signed in to change notification settings - Fork 53
Add general parameters to haddock3-cfg client
#476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 72.22% 72.32% +0.10%
==========================================
Files 95 95
Lines 6080 6103 +23
==========================================
+ Hits 4391 4414 +23
Misses 1689 1689
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the global parameter vary per module? If not why not have a separate listing for those instead of adding the -g option to all modules?
|
Global parameters do not vary per module. We can have a separate listing, but it should be in the same command line. For example:
I think these options should be kept in the same command-line because in this way there's a single place to read the docs. What do you think? I can make it in this same PR. |
|
Sounds like a good idea! |
|
Add what we discussed @amjjbonvin . But Instead of
|
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:
toxtests pass. Runtoxcommand inside the repository folder-test.cfgexamples execute without errors. Insideexamples/runpython run_tests.py -bNow,
haddock3-cfgcan also output the general parameters for modules combined with those of the requested module.