Skip to content

Conversation

@joaomcteixeira
Copy link
Member

@joaomcteixeira joaomcteixeira commented Jun 13, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Corrects the moment when the module's names are checked in the configuration file.

@joaomcteixeira joaomcteixeira self-assigned this Jun 13, 2022
@joaomcteixeira joaomcteixeira added bug Something isn't working workflow All the general parts of HADDOCK3 not related to any module in particular labels Jun 13, 2022
@joaomcteixeira joaomcteixeira added this to the v3.0.0 stable release milestone Jun 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #477 (e460994) into main (5abbdf3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files          95       95           
  Lines        6080     6080           
=======================================
  Hits         4391     4391           
  Misses       1689     1689           
Impacted Files Coverage Δ
src/haddock/gear/prepare_run.py 45.86% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abbdf3...e460994. Read the comment docs.

@joaomcteixeira joaomcteixeira merged commit 0dad275 into haddocking:main Jun 13, 2022
@joaomcteixeira joaomcteixeira deleted the check_modules_names branch June 13, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working workflow All the general parts of HADDOCK3 not related to any module in particular

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants