Skip to content

Conversation

@joaomcteixeira
Copy link
Member

@joaomcteixeira joaomcteixeira commented Jul 20, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

@joaomcteixeira joaomcteixeira requested a review from mgiulini July 20, 2022 08:47
@joaomcteixeira joaomcteixeira self-assigned this Jul 20, 2022
@joaomcteixeira joaomcteixeira added bug Something isn't working m|topoaa topoaa module labels Jul 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #500 (22044c2) into main (e81d302) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   72.36%   72.37%   +0.01%     
==========================================
  Files          96       96              
  Lines        6203     6202       -1     
==========================================
  Hits         4489     4489              
+ Misses       1714     1713       -1     
Impacted Files Coverage Δ
src/haddock/modules/topology/topoaa/__init__.py 44.06% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81d302...22044c2. Read the comment docs.

@joaomcteixeira joaomcteixeira merged commit 3a144ea into haddocking:main Jul 20, 2022
@joaomcteixeira joaomcteixeira deleted the limittopo branch July 20, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working m|topoaa topoaa module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants