Skip to content

Conversation

@mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Sep 9, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #550

@mgiulini mgiulini self-assigned this Sep 9, 2022
@mgiulini mgiulini requested a review from rvhonorato September 9, 2022 14:00
@mgiulini mgiulini merged commit 13b221e into main Sep 15, 2022
@mgiulini mgiulini deleted the iss550 branch September 15, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove sampling parameter from emref

3 participants