Skip to content

Conversation

@mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Nov 29, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #589 by setting the attribute restr_fname to None when models to be refined have yet to be merged

@mgiulini mgiulini self-assigned this Nov 29, 2022
@joaomcteixeira
Copy link
Member

This one is deep; I can't consider all the implications of this change by heart without being 100% into the project. I suggest inspecting tests and results with the compare_runs.py script in the examples/. Ping me if any questions about those scripts. 👍

@amjjbonvin
Copy link
Member

amjjbonvin commented Dec 1, 2022 via email

@mgiulini mgiulini merged commit 0908736 into main Dec 1, 2022
@mgiulini mgiulini linked an issue Dec 1, 2022 that may be closed by this pull request
@mgiulini mgiulini deleted the fix_refinement_restr_fname branch January 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix handling of restr_fname attribute in refinement modules

4 participants