Skip to content

Conversation

@mgiulini
Copy link
Contributor

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #635

@mgiulini mgiulini self-assigned this Mar 13, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.33 ⚠️

Comparison is base (fe2d829) 73.81% compared to head (7f4fb2d) 73.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   73.81%   73.48%   -0.33%     
==========================================
  Files         110      110              
  Lines        7347     7347              
==========================================
- Hits         5423     5399      -24     
- Misses       1924     1948      +24     
Impacted Files Coverage Δ
src/haddock/clis/cli.py 33.33% <0.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgiulini mgiulini marked this pull request as ready for review March 13, 2023 19:19
@mgiulini mgiulini requested a review from amjjbonvin March 13, 2023 19:19
@mgiulini mgiulini merged commit 64a57bc into main Mar 13, 2023
@mgiulini mgiulini deleted the bug_postprocess branch March 13, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

correct bug postprocess

4 participants