Skip to content

Conversation

@mgiulini
Copy link
Contributor

@mgiulini mgiulini commented May 1, 2023

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #647

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.32 ⚠️

Comparison is base (33b5155) 74.58% compared to head (cd3793c) 74.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   74.58%   74.26%   -0.32%     
==========================================
  Files         111      111              
  Lines        7565     7565              
==========================================
- Hits         5642     5618      -24     
- Misses       1923     1947      +24     
Impacted Files Coverage Δ
src/haddock/clis/cli_analyse.py 73.75% <ø> (ø)
src/haddock/libs/libalign.py 67.85% <0.00%> (ø)
src/haddock/libs/libplots.py 96.17% <ø> (ø)
src/haddock/modules/analysis/caprieval/capri.py 82.39% <ø> (ø)
src/haddock/modules/analysis/clustrmsd/__init__.py 90.99% <ø> (ø)
tests/test_module_clustrmsd.py 100.00% <ø> (ø)
src/haddock/__init__.py 96.29% <100.00%> (ø)
tests/test_cli_analyse.py 97.77% <100.00%> (ø)
tests/test_libalign.py 100.00% <100.00%> (ø)
tests/test_module_flexref.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rvhonorato
Copy link
Member

I've fixed all the versions in the ci pipeline, I don't know if there was a reson for them to not be fixed or if it was just a mistake 🔮

there were also some linting issues that I've added FIXME or noqa, imo we should not be waisting time doing this manually when there are ways to automate this code formating.

@rvhonorato rvhonorato merged commit 241d502 into main May 1, 2023
@rvhonorato rvhonorato deleted the correct_lint branch May 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

correct linting

4 participants