Skip to content

Conversation

@rvhonorato
Copy link
Member

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Delete this line and explain your PR here

@rvhonorato rvhonorato linked an issue Sep 1, 2023 that may be closed by this pull request
@rvhonorato rvhonorato self-assigned this Sep 1, 2023
@rvhonorato rvhonorato added the CI / repository Continuous integration or repository organization label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 95.09% and project coverage change: +0.31% 🎉

Comparison is base (4eea155) 74.78% compared to head (8c963e6) 75.10%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   74.78%   75.10%   +0.31%     
==========================================
  Files         113      113              
  Lines        7948     8042      +94     
==========================================
+ Hits         5944     6040      +96     
+ Misses       2004     2002       -2     
Files Changed Coverage Δ
src/haddock/modules/analysis/caprieval/capri.py 82.63% <93.75%> (+0.24%) ⬆️
src/haddock/libs/libalign.py 74.85% <94.59%> (+7.00%) ⬆️
tests/test_libalign.py 100.00% <100.00%> (ø)
tests/test_module_caprieval.py 97.60% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvhonorato rvhonorato merged commit 1dca207 into main Sep 1, 2023
@rvhonorato rvhonorato deleted the 692-update-tox-version branch September 1, 2023 07:39
@rvhonorato rvhonorato mentioned this pull request Sep 1, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI / repository Continuous integration or repository organization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tox version

2 participants