-
Notifications
You must be signed in to change notification settings - Fork 53
Input to json #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input to json #705
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 74.92% 74.97% +0.05%
==========================================
Files 113 113
Lines 8035 8048 +13
==========================================
+ Hits 6020 6034 +14
+ Misses 2015 2014 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite dangerous to modify a function name that is used all around the software !
I have double checked that all files containing this functions were modified, and it should run smoothly.
! Just that people may have to modify this function call in unmerged branches too !
Do we want a to temporarly add a deprection warning and a function wrapper ?
def export_output_models(self, *args, **kwargs):
self.export_io_models(*args, **kwargs)
print('WARNING: function export_output_models is depecated, use export_io_models instead')?
no need for that: as soon as this PR is accepted and merged into the main branch, any further modification will have to merge the main into itself, possibly highlighting a conflict. I am adding a test to this function though, to make it pass the patch coverage test. |
|
added a new test, but it's not enough for the patch coverage to pass..It does not make sense to create 12 new tests, so I would skip it and merge this as is. |
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
toxtests pass. Runtoxcommand inside the repository folder-test.cfgexamples execute without errors. Insideexamples/runpython run_tests.py -bCloses #704 by adding information about input models in the io.json file of each module. This makes each module self-describing, i.e., all the I/O information is present in the module directory, thus facilitating the information retrieval.
An example application of this will be provided in the implementation of interactive commands (#686) that have to deal with small pieces of a HADDOCK3 run (modules) without having access to the whole run folder.