Skip to content

Conversation

@mgiulini
Copy link
Contributor

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #830 by ordering the traceback table according to the last column

@mgiulini mgiulini self-assigned this Mar 20, 2024
@mgiulini mgiulini added enhancement Improving something in the codebase analysis/postprocessing related to the analysis/postprocessing of a haddock3 run labels Mar 20, 2024
@mgiulini mgiulini marked this pull request as ready for review March 20, 2024 09:37
@mgiulini mgiulini requested a review from VGPReys March 20, 2024 14:33
@mgiulini mgiulini changed the title added ordering step ordered traceback Mar 20, 2024
Copy link
Contributor

@VGPReys VGPReys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sorting based on last column, which makes sense.
But could it be also sorted based on previous columns for initial models that did not make it until the end of the workflow ?
e.g:
[rigibody]
sampling = 1000
[seletop]
select = 200
[flexref]

in the example, the traceback would sort based on flexref, but randomize order for rigidbody models 201 to 1000.

@mgiulini
Copy link
Contributor Author

This is sorting based on last column, which makes sense. But could it be also sorted based on previous columns for initial models that did not make it until the end of the workflow ? e.g: [rigibody] sampling = 1000 [seletop] select = 200 [flexref]

in the example, the traceback would sort based on flexref, but randomize order for rigidbody models 201 to 1000.

fair point, it should be quite easy!

@mgiulini
Copy link
Contributor Author

@VGPReys done! it should be fixed now

@VGPReys
Copy link
Contributor

VGPReys commented Mar 27, 2024

@VGPReys done! it should be fixed now

Nice amazing !

@mgiulini mgiulini merged commit a6a392f into main Mar 27, 2024
@mgiulini mgiulini deleted the ordered_traceback branch March 27, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analysis/postprocessing related to the analysis/postprocessing of a haddock3 run enhancement Improving something in the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

order traceback table

3 participants