Skip to content

create new CNSScoringModule class #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2024
Merged

create new CNSScoringModule class #870

merged 2 commits into from
Apr 24, 2024

Conversation

@VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Apr 19, 2024

Closes #869 by splitting scoring modules into two classes:

  • CNSScoringModule
  • ScoringModule

They both have access to the ScoringModule method self.output(), writing the final tsv file.

@VGPReys VGPReys self-assigned this Apr 19, 2024
@VGPReys VGPReys requested a review from mgiulini April 22, 2024 06:51
mgiulini
mgiulini approved these changes Apr 24, 2024
View reviewed changes
@VGPReys @mgiulini
Update src/haddock/modules/scoring/__init__.py
13221a1 
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
@VGPReys VGPReys added the enhancement Improving something in the codebase label Apr 24, 2024
@VGPReys VGPReys merged commit 177121a into main Apr 24, 2024
@VGPReys VGPReys deleted the inheritance-scoring-module branch April 24, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgiulini mgiulini mgiulini approved these changes

Assignees

@VGPReys VGPReys

Labels

enhancement Improving something in the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modify scoring module class to accept non CNS Modules

3 participants

@VGPReys @mgiulini