Skip to content

Conversation

@amjjbonvin
Copy link
Member

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Added check for empty string before fileexist statements in CNS code (only for instances where there is the possibility of an empty string).

@amjjbonvin amjjbonvin added bug Something isn't working m|emscoring Related to emscoring module m|emref emref module m|flexref flexref module m|mdref mdref module m|rigidbody rigidbody sampling m|topoaa topoaa module m|mdscoring mdscoring module labels Sep 2, 2024
@amjjbonvin amjjbonvin self-assigned this Sep 2, 2024
@amjjbonvin amjjbonvin marked this pull request as draft September 2, 2024 15:50
@amjjbonvin amjjbonvin marked this pull request as ready for review September 2, 2024 18:08
@rvhonorato rvhonorato changed the title Address issue #993 avoid fileexist on empty strings Sep 3, 2024
@rvhonorato rvhonorato added the CNS Improvements in the CNS engine label Sep 3, 2024
Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Fixing the issue directly at the source instead of patching it upstream 🎉

@rvhonorato rvhonorato linked an issue Sep 6, 2024 that may be closed by this pull request
@amjjbonvin amjjbonvin merged commit 9f36e4f into main Sep 6, 2024
@amjjbonvin amjjbonvin deleted the fileexist branch September 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CNS Improvements in the CNS engine m|emref emref module m|emscoring Related to emscoring module m|flexref flexref module m|mdref mdref module m|mdscoring mdscoring module m|rigidbody rigidbody sampling m|topoaa topoaa module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logic inconsistency when checking if file exists

4 participants