Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 'install_remote()' #1481

Closed
wants to merge 3 commits into from

Conversation

dy-kim
Copy link

@dy-kim dy-kim commented Mar 23, 2017

Changes

  • Making install_remote() smaller to improve readability
    • Modularize the codes of checking conditions to skip installation as a function check_if_skip_install_remote
  • Remove duplicated codes in install()
    • Previously, the lines 33 ~ 39 of install-remote.R and the lines 96 ~ 102 of install.R were duplicated.
    • This update will replace those duplication as a skip_since_log_exists()
  • Fix Bug in install() - Wrong argument passing in pkgbuild::rcmd_build_tools() usage #1491

@hadley
Copy link
Member

hadley commented Aug 2, 2017

Thanks - this should go to remotes too please.

@hadley hadley closed this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants