build: if pdflatex not present, don't build vignettes. Fixes #173 #216

Merged
merged 4 commits into from Dec 16, 2012

Projects

None yet

2 participants

@wch
Collaborator
wch commented Dec 15, 2012

Fixes #173. If pdflatex isn't present, then build() won't try to build the vignettes.

@hadley
Owner
hadley commented Dec 16, 2012

Can we do this for check() too?

@wch
Collaborator
wch commented Dec 16, 2012

Sure. But should something be done to ensure that a full check is done before a release?

@hadley
Owner
hadley commented Dec 16, 2012

Just a strongly worded warning should be sufficient. It'll be helpful for classes.

@hadley hadley closed this Dec 16, 2012
@hadley hadley reopened this Dec 16, 2012
@wch
Collaborator
wch commented Dec 16, 2012

OK, I've made the wording a bit stronger, rebased, and added a NEWS item.

@wch wch merged commit 98d1ca6 into hadley:master Dec 16, 2012
@hadley hadley commented on the diff Dec 16, 2012
R/check.r
@@ -63,6 +63,12 @@ check_r_cmd <- function(built_path = NULL, cran = TRUE, check_version = FALSE,
pkgname <- gsub("_.*?$", "", basename(built_path))
opts <- "--timings"
+ if (!nzchar(Sys.which("pdflatex"))) {
@hadley
hadley Dec 16, 2012 Owner

I think we also want to disable building the manual here too

@wch
wch Dec 16, 2012 Collaborator

Sure, done in 72ce098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment