Skip to content

Don't use a factor for ID column if .id parameter is not set in ldply() and rdply() #195

Merged
merged 3 commits into from Jan 15, 2014

2 participants

@krlmlr
krlmlr commented Jan 10, 2014

This is to ensure backward compatibility with the many packages that depend on plyr, e.g., ggplot2

Also: Roxygenize to set C sorting of family-generated documentation

@krlmlr krlmlr referenced this pull request Jan 10, 2014
Merged

Enhancements for *dply #188

@hadley hadley and 1 other commented on an outdated diff Jan 10, 2014
#' @export
ldply <- function(.data, .fun = NULL, ..., .progress = "none", .inform = FALSE,
- .parallel = FALSE, .paropts = NULL, .id = ".id") {
+ .parallel = FALSE, .paropts = NULL, .id) {
@hadley
Owner
hadley added a note Jan 10, 2014

Could you set the default to NA. I think the use of missing() is confusing, because then you can't easily tell which arguments are optional and which are required.

@krlmlr
krlmlr added a note Jan 10, 2014

Done. (Why can't RStudio remove whitespace at end of line?)

@hadley
Owner
hadley added a note Jan 10, 2014

That's one of my feature requests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
krlmlr added some commits Jan 10, 2014
@krlmlr krlmlr Don't use a factor for ID column if .id parameter is not set in ldply…
…() and rdply()

This is to ensure backward compatibility with the many packages that depend on plyr, e.g., ggplot2
cd1633e
@krlmlr krlmlr Roxygenize 618ee2e
@hadley hadley commented on the diff Jan 15, 2014
@@ -6,8 +6,9 @@
* New parameter `.id` to `rdply()` that specifies the name of the index column.
(Thanks to Kirill Müller, #142)
-* The .id column in ldply() is generated as a factor to preserve the sort order.
- (Thanks to Kirill Müller, #137)
+* The .id column in `ldply()` and `rdply()` is generated as a factor to preserve
@hadley
Owner
hadley added a note Jan 15, 2014

I'll go through and fix these before release, but since I've switched to markdown you can thank yourself with @klmlr and it'll get linked to your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@hadley hadley merged commit 4053c42 into hadley:master Jan 15, 2014

1 check passed

Details default The Travis CI build passed
@hadley
Owner
hadley commented Jan 15, 2014

Thanks!

@krlmlr krlmlr deleted the krlmlr:id-na branch Jan 20, 2014
@krlmlr krlmlr referenced this pull request in hadley/ggplot2 Jan 27, 2014
Closed

facet_wrap errors #901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.