Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Promote .inform to an explicit argument. #57

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

For [d|l|a][d|l|a]ply, make the .inform paramter and explicit parameter
to the functions. Added the documentation for .inform to the ply
documentation template. Passed the value through to the underlying
plyr function. Re-oxygenized.

Addresses a request from Issue #50.

Owner

hadley commented Aug 16, 2011

Does this pass R CMD check?

It passed devtools::check(). I didn't try R CMD check separately. Does that need to be checked as well?

Owner

hadley commented Aug 16, 2011

No, that's perfect.

Owner

hadley commented Oct 5, 2012

You could please rebase your changes?

Promote .inform to an explicit argument.
For [d|l|a][d|l|a]ply, make the .inform paramter and explicit parameter
to the functions.  Added the documentation for .inform to the ply
documentation template.  Passed the value through to the underlying
plyr function. Re-oxygenized.

I believe I have successfully rebased this commit. I can't get it to pass check because I don't have (and can't install) doMC. That said, the documentation builds correctly and the tests pass up to the parallel tests (which fail for the same doMC reason).

Owner

hadley commented Oct 11, 2012

Doh, I just made a whole lot of changes that will conflict with this :( I'll just integrate by hand! (On the plus side I also found a whole lot of places where plyr wasn't quite consistent)

@hadley hadley closed this in b665d95 Oct 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment