Error (and crash) in dcast with NA values when drop=FALSE #24

Closed
huftis opened this Issue Aug 8, 2012 · 1 comment

Comments

Projects
None yet
2 participants

huftis commented Aug 8, 2012

I’ve found a bug in dcast in reshape, where NA values are not correctly handled if drop=FALSE. Example:

library(reshape2)
d = data.frame(x = c(10, 10), y = c("A", NA), z=1:2)
# d$y = as.character(d$y)
d2 = melt(d, measure.vars="z")
dcast(d, x+y~., fun=sum, value.var="z", drop=FALSE)

The actual error message depends on whether y is a factor or a character vector (run the commented line). When it’s a factor vector, the error message says:

Error in split_indices(seq_along(.value), .group, .n) :
   INTEGER() can only be applied to a 'integer', not a 'pairlist'

When it’s a character vector, it says:

Error: nrow(res$labels[[1]]) == nrow(data) is not TRUE

And the most surprising thing is that if y is a factor vector and I repeatedly run the dcast line, R actually crashes. This is 100% reproducible: One Windows it crashes the third time the dcast line is run, and on Linux it crashes the first time. I can also reproduce it with the latest Git version.

--please do not edit the information below--

Package: reshape2
Version: 1.2.1
Maintainer: Hadley Wickham hadley@rice.edu
Built: R 2.15.1; ; 2012-06-23 16:36:47 UTC; windows

R Version:
platform = i386-pc-mingw32
arch = i386
os = mingw32
system = i386, mingw32
status =
major = 2
minor = 15.1
year = 2012
month = 06
day = 22
svn rev = 59607
language = R
version.string = R version 2.15.1 (2012-06-22)
nickname = Roasted Marshmallows

Windows XP (build 2600) Service Pack 3

Locale:
LC_COLLATE=Norwegian-Nynorsk_Norway.1252;LC_CTYPE=Norwegian-Nynorsk_Norway.1252;LC_MONETARY=Norwegian-Nynorsk_Norway.1252;LC_NUMERIC=C;LC_TIME=Norwegian-Nynorsk_Norway.1252

Search Path:
.GlobalEnv, package:reshape2, package:stats, package:graphics,
package:grDevices, package:datasets, package:utils, package:methods,
Autoloads, package:base

Owner

hadley commented Nov 27, 2013

With the dev version of plyr, this at least no longer crashes.

hadley closed this in 5937e23 Nov 27, 2013

@duncandoo duncandoo added a commit to duncandoo/reshape that referenced this issue Jun 23, 2014

@hadley @duncandoo hadley + duncandoo Better handling of .
Fixes #24. Fixes #6
4cb43ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment