Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

Saving/loading window dimensions and position broken #51

Closed
HeikoAdams opened this issue Aug 17, 2016 · 6 comments
Closed

Saving/loading window dimensions and position broken #51

HeikoAdams opened this issue Aug 17, 2016 · 6 comments
Assignees
Milestone

Comments

@HeikoAdams
Copy link

HeikoAdams commented Aug 17, 2016

In latest git master saving or loading the window dimensions and position is broken.

@haecker-felix haecker-felix self-assigned this Aug 17, 2016
@haecker-felix haecker-felix added this to the Gradio 4.1 milestone Aug 17, 2016
@kopr12
Copy link

kopr12 commented Aug 17, 2016

That's weird, it wasn't working for me before but now it is.
What do you mean by broken ?
It's not saving or loading at all , or it does but it's wrong ?
Was it working before ?

@HeikoAdams
Copy link
Author

That means if I close gradio maximized the window isn't maximized on next start. And if I close gradio with a normal window placed centered on screen the window isn't on that position on next startup of gradio

@kopr12
Copy link

kopr12 commented Aug 17, 2016

Hmm, just tried that several times with other various combinations and it works.

Well, I don't know, might be the distro or something, I guess you will have to wait for author to come back and see what's going on.

@dasnoopy
Copy link
Contributor

dasnoopy commented Aug 19, 2016

Maybe could help: I noticed that (at least for me) store of window dimension and its position on quit doesn't work as expected if I disable "Close to tray" option;

If I leave enabled "Close to tray" option, dimension and position are saved on quit and loaded on next start successfully.

Gradio latest commit 530ddde (139) on Archlinux 64bit and gnome 3.20.2

@kopr12
Copy link

kopr12 commented Aug 19, 2016

That helps, indeed it doesn't work in that case, it's interesting that it does work with "Close to tray" disabled if you choose "Quit" from the app menu or "Quit" from systray, but if you close the window by clicking X on window then it doesn't.
Funny, anyway I'll try to see what's going on with that.

haecker-felix added a commit that referenced this issue Aug 19, 2016
Fix saving window geometry #51
@haecker-felix
Copy link
Owner

Should be fixed. Thanks @kajzersoze!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants