Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
add support for snap package building #197
Conversation
diddledan
added some commits
Aug 15, 2017
|
Thanks for this work! I'm currently on holiday and only have limited Internet access, so I cannot check it right now. |
|
Looks fine, I'm going to create a new repo for the snap package, i dont want to include package specific code to the main repo. |
haecker-felix
merged commit a195add
into
haecker-felix:master
Aug 29, 2017
|
Hm i have issues with building a snap package with build.snapcraft.io
Maybe you can help me |
|
@diddledan i want to keep the main repo clean of package specific code (snap/deb/rpm). Whats the best way to do this? I could add a new branch for the snap package code, but unfortunately on build.snapcraft.io i cannot specify a other branch. The other possibility would be, create a complete new repo, same as the main repo + the snap package code. But so i have to push it every time to two repos. This is also not the greatest way. I think the best way would be, creating a new repo, which only contains the snap specific code (for example https://github.com/8none1/corebird-snap), and use this one for snapcraft.io I'm still experimenting with snap ;) |
|
I think build.snapcraft.io expects to be building from master each time. It would be nice to allow branching but it isn't available in the service at the moment. To use a separate repo, you will have to bump the snap repo each time you want to cut a new release. You'll not get the ability to track regular builds whenever the main repo changes, but on the flip side you get to keep the packaging info out of the main tree. With Corebird, at https://github.com/snapcrafters/corebird now, we're maintaining it until such time that upstream are able and willing to include it in their own processes at which time they'd take control and either create a snap-specific repo or import the snapcraft stuff into the mainline tree. Alternatively, if they state that they do not want to adopt it, we will continue maintaining the snap packaging independently. |
|
I'm going to do it like the corebird snap. I think thats the best way for me. https://github.com/gradio-app/gradio-snap Unfortunately i'm still unable to build the snap on snapcraft.io. I don't know whats wrong. Maybe you can help me. (if not i'm going to ask it in the snapcraft forum) Build # 74231
|
diddledan commentedAug 15, 2017
credits to @popey for the basis of this commit. Finalised and tested by @diddledan.