Feature/bodies #71

haf · 2015-04-05T13:08:53Z

A PR based on the previous two PRs, aiming to fix #65

haf · 2015-04-06T09:06:05Z

this PR is the one I really care about ;). Or the stuff that starts from the first [requestbody] commit to be specific.

haf · 2015-04-06T15:49:29Z

Rebasing against master.

relentless · 2015-04-06T16:01:30Z

I'll just wait until you're done then. Will this include the Fuchu changes as well?

haf · 2015-04-06T16:06:33Z

Yes

haf · 2015-04-06T16:07:18Z

New issue after rebase: #82

haf · 2015-04-06T16:08:58Z

Rebase done. Afk for a while now. You should be able to test this.

relentless · 2015-04-06T17:36:33Z

Not sure what's going on here, there seems to be some issue with the Fsharp.core reference in the unit tests, and the integration tests hang at some point.

relentless · 2015-04-06T21:56:59Z

The fsharp.core redirect in the unit test project needs updating to 4.3.1. I'm getting two failures now, related to the multi-part file upload:

formatting different sorts of body/can format multipart/formdata single file: Failed:
should have correct body
Expected: "Content-Type: multipart/form-data; boundary=mACKqCcIID-J''_PL:hfbFiOLC/cew

--mACKqCcIID-J''_PL:hfbFiOLC/cew
Content-Disposition: form-data; name="submit-name"

Larry
--mACKqCcIID-J''_PL:hfbFiOLC/cew
Content-Disposition: form-data; name="files"; filename="file1.txt"
Content-Type: text/plain

Hello World
--mACKqCcIID-J''_PL:hfbFiOLC/cew--"
Actual: "Content-Type: multipart/form-data; boundary=nLWsTCFurKCiU_PjC/cCmmU-tnJHHa

--nLWsTCFurKCiU_PjC/cCmmU-tnJHHa
Content-Disposition: form-data; name="submit-name"

Larry
--nLWsTCFurKCiU_PjC/cCmmU-tnJHHa
Content-Disposition: form-data; name="files"; filename="file1.txt"
Content-Type: text/plain

Hello World
--nLWsTCFurKCiU_PjC/cCmmU-tnJHHa--"
g:\prg\Fuchu\Fuchu\Assertions.fs(13,1): <StartupCode$Fuchu>.$Assertions.Equal@13.Invoke(String msg)
(00:00:00.0334506)

formatting different sorts of body/can format multipart/formdata with multipart/mixed for multi-file upload: Failed:
should have correct body
Expected: "Content-Type: multipart/form-data; boundary=mACKqCcIID-J''_PL:hfbFiOLC/cew

--mACKqCcIID-J''_PL:hfbFiOLC/cew
Content-Disposition: form-data; name="submit-name"

Larry
--mACKqCcIID-J''_PL:hfbFiOLC/cew
Content-Type: multipart/mixed; boundary=iDnsCZhfTqMSYsj:LhBTftNfVog:eA
Content-Disposition: form-data; name="files"

--iDnsCZhfTqMSYsj:LhBTftNfVog:eA
Content-Disposition: file; filename="file1.txt"
Content-Type: text/plain

Hello World
--iDnsCZhfTqMSYsj:LhBTftNfVog:eA
Content-Disposition: file; filename="file2.gif"
Content-Type: text/plain

...contents of file2.gif...
--iDnsCZhfTqMSYsj:LhBTftNfVog:eA--
--mACKqCcIID-J''_PL:hfbFiOLC/cew--"
Actual: "Content-Type: multipart/form-data; boundary=nLWsTCFurKCiU_PjC/cCmmU-tnJHHa

--nLWsTCFurKCiU_PjC/cCmmU-tnJHHa
Content-Disposition: form-data; name="submit-name"

Larry
--nLWsTCFurKCiU_PjC/cCmmU-tnJHHa
Content-Type: multipart/mixed; boundary=BgOE:fCUQGnYfKwGMnxoyfwVMbRzZF
Content-Disposition: form-data; name="files"

--BgOE:fCUQGnYfKwGMnxoyfwVMbRzZF
Content-Disposition: file; filename="file1.txt"
Content-Type: text/plain

Hello World
--BgOE:fCUQGnYfKwGMnxoyfwVMbRzZF
Content-Disposition: file; filename="file2.gif"
Content-Type: text/plain

...contents of file2.gif...
--BgOE:fCUQGnYfKwGMnxoyfwVMbRzZF--
--nLWsTCFurKCiU_PjC/cCmmU-tnJHHa--"
g:\prg\Fuchu\Fuchu\Assertions.fs(13,1): <StartupCode$Fuchu>.$Assertions.Equal@13.Invoke(String msg)

relentless · 2015-04-06T22:05:25Z

Also, the integration tests hang on this:

***** HttpClient_SuaveIntegrationTests+Suave Integration Tests.server receives valid filenames
get response body
[I] 2015-04-06T21:47:59.5908870Z: listener started in 97.069 ms with binding 127.0.0.1:8083 [Suave.Tcp.tcp_ip_server]
[V] 2015-04-06T21:48:00.6253196Z: 127.0.0.1 connected, total: 1 clients [Suave.Tcp.tcp_ip_server.job]
[V] 2015-04-06T21:48:00.6323246Z: reserving buffer: 811008, free count: 99 [Suave.Tcp.tcp_ip_server.job] [Suave.Socket.BufferManager]
[V] 2015-04-06T21:48:00.6423316Z: -> processor [Suave.Web.request_loop.loop]
[V] 2015-04-06T21:48:00.6633465Z: reserving buffer: 802816, free count: 98 [Suave.Web.read_till_pattern.loop] [Suave.Socket.BufferManager]
[V] 2015-04-06T21:48:00.7053906Z: freeing buffer: 802816, free count: 99 [Suave.Web.split] [Suave.Socket.BufferManager]
[V] 2015-04-06T21:48:00.7364162Z: reserving buffer: 802816, free count: 98 [Suave.Web.read_till_pattern.loop] [Suave.Socket.BufferManager]
[V] 2015-04-06T21:48:00.9904504Z: tcp request processing failed [Suave.Tcp.tcp_ip_server.job] exn:
System.Exception: did not find header, because header_params received None
at Suave.Utils.Parsing.headerParams(FSharpOption1 header) at Suave.Web.ParsingAndControl.loop@207-31.Invoke(Tuple2 _arg2)
at Microsoft.FSharp.Control.AsyncBuilderImpl.args@787-1.Invoke(a a)

haf · 2015-04-07T07:46:04Z

The first error is interesting; because it means Random(seed) has different implementations on mono vs .Net

haf · 2015-04-07T08:49:09Z

So it turns out RFC1867 that I coded against isn't actually implemented by web servers, and all web servers simply repeat the form-name for multiple files. Gaah.

http://stackoverflow.com/questions/16976299/how-to-create-an-html-form-to-send-http-message-with-multipart-mixed-mime-type/29487399#29487399

haf · 2015-04-07T08:53:51Z

http://stackoverflow.com/questions/4526273/what-does-enctype-multipart-form-data-mean/28380690#28380690 is another QA about this

haf · 2015-04-07T08:56:34Z

Wow, what a yak.

At least now there are passing integration tests =). Ok, please review again.

Touched: - Issue #73; added TODO - Fixed #75; upper-cased methods - Fixed #72; BREAKING change -- defaulted to UTF8 - Fixed #69; BREAKING change -- all methods take Encoding - Fixed #68; BREAKING change -- made all things that are naturally empty, empty. - Issue #65; almost done, the rest is easy

This way; if you use the typed API, you get the "auto-correct" Content-Type. If you use the BodyString (for e.g. JSON) or BodyRaw you get to set Content-Type by yourself like previously.

- open HttpClient -> open HttpFs.Client - Started moving rough edges out of Client.fs

haf · 2015-05-20T11:21:13Z

Now we have integration tests for sending a binary file, too that are passing with the latest Suave.

haf · 2015-05-20T13:39:45Z

Latest suave https://twitter.com/SuaveIO/status/601018318280126464 -- works on my machine =)

haf · 2015-05-20T15:31:51Z

I have updated the namespaces here, too.

haf · 2015-05-20T18:20:23Z

So on Windows, on AppVeyor, something is obviously deadlocking / locking the async and that never returns. Since the web server runs to completion, sending all its data, I'm a bit surprised. Any insights?

haf · 2015-05-21T08:09:02Z

Some feedback now that all issues have been solved would be great!

relentless · 2015-05-21T08:53:20Z

Good work, nice green builds! I'm due a 'learning day' at work, so I'll take that soon and try to go through all you've done. (Although there's a lot to go through!)

…ered in depth

This refactor closes almost all outstanding issues. - Introduces a Logging abstraction, fixes #80 - Previously: not version Releases -- fixes #78 - Previously: explicit state -- fixes #77 - Uses Map which has something like O(log n) -- fixes 76 - Username/password in UTF8 - fixes #73 - Fixes #72 by defaulting everything to UTF-8 - Fixes #67 by overwriting headers set n times - Previously: Fixes #65 about form bodies - Sets Expect100Continue to false, since we've overridden the GetResponseStream() interaction and always send all of the request. - Cleans up indexing into response.Headers to be functional instead of imperative - Improved docs on BodyForm

haf · 2015-05-27T10:22:43Z

Request for merge!

Feature/bodies

relentless · 2015-05-27T11:39:27Z

OK, have merged. Still want to check a few things, and want to go through it before making a NuGet.

haf · 2015-05-27T12:51:36Z

Yes, you should -- I absolutely want feedback and to reach consensus. How about we create issues for each discussion point, and you can cc @haf?

haf added 17 commits April 7, 2015 10:57

[unittests] rewritten in part to Fuchu

fd6f6e0

[unittests] already tested in "defaults" test above

aa3e14a

[unittests] finished Fuchu conversion

5e73382

[requestbody] extract tests to its own file

20e68d5

[requestbody] stubbing out use-cases

6952870

[requestbody] a possible typed API

b44e558

[integration-tests] passing.

4a5e3d6

[requestbody] passing tests for multi-uploads

e6fc4f5

[requestbody] passing test for 'can format urlencoded'

842cd9d

[requestbody] support for urlencode formatting

158de38

[requestbody] support fixup of Content-Type based on body;

3d18f5e

This way; if you use the typed API, you get the "auto-correct" Content-Type. If you use the BodyString (for e.g. JSON) or BodyRaw you get to set Content-Type by yourself like previously.

[infra] is AppVeyor happy now?

6d3d8ea

[requestbody] adding comment about overriding Content-Type

ff42229

[requestbody] removing notes

6e4337f

[requestbody] adding failing integration test for suave

701d0ac

[infra] adding build.sh to bootstrap compilation

64e361b

haf added 4 commits May 18, 2015 14:53

new name: HttpFs from HttpClient, reorg

2c5b083

- open HttpClient -> open HttpFs.Client - Started moving rough edges out of Client.fs

towards all-passing integration tests

2dccc74

passing integration tests

ce55a12

[tests] passing tests for latest suave - works to pass stream

457db62

haf added 2 commits May 20, 2015 13:24

v2.2.0

9070937

[infra] upgrade suave

0afec76

[infra] update build.fsx to match reality

e60f345

haf added 3 commits May 20, 2015 17:36

[tests] Windows streams workaround

99964d9

[tests] Windows streams workaround 2

e3c1f60

[tests] more Windows - increasing logging level to see where it hangs

c91d67b

haf added 3 commits May 21, 2015 09:43

[tests] more testing of bodies

2bf4b85

[tests] upgrade Suave.Testing

1f6da6b

v2.2.1

5f71d14

haf added 5 commits May 22, 2015 18:49

[client] only set query if we don't have one -- this should be consid…

0db61aa

…ered in depth

Update README.md

67317a6

[client] implement GetHashCode()

ddf2b29

[infra] v2.3.0

4092feb

relentless added a commit that referenced this pull request May 27, 2015

Merge pull request #71 from haf/feature/bodies

9d0ab0a

Feature/bodies

relentless merged commit 9d0ab0a into haf:master May 27, 2015

haf deleted the feature/bodies branch May 27, 2015 12:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/bodies #71

Feature/bodies #71

haf commented Apr 5, 2015

haf commented Apr 6, 2015

haf commented Apr 6, 2015

relentless commented Apr 6, 2015

haf commented Apr 6, 2015

haf commented Apr 6, 2015

haf commented Apr 6, 2015

relentless commented Apr 6, 2015

relentless commented Apr 6, 2015

relentless commented Apr 6, 2015

haf commented Apr 7, 2015

haf commented Apr 7, 2015

haf commented Apr 7, 2015

haf commented Apr 7, 2015

haf commented May 20, 2015

haf commented May 20, 2015

haf commented May 20, 2015

haf commented May 20, 2015

haf commented May 21, 2015

relentless commented May 21, 2015

haf commented May 27, 2015

relentless commented May 27, 2015

haf commented May 27, 2015

Feature/bodies #71

Feature/bodies #71

Conversation

haf commented Apr 5, 2015

haf commented Apr 6, 2015

haf commented Apr 6, 2015

relentless commented Apr 6, 2015

haf commented Apr 6, 2015

haf commented Apr 6, 2015

haf commented Apr 6, 2015

relentless commented Apr 6, 2015

relentless commented Apr 6, 2015

relentless commented Apr 6, 2015

haf commented Apr 7, 2015

haf commented Apr 7, 2015

haf commented Apr 7, 2015

haf commented Apr 7, 2015

haf commented May 20, 2015

haf commented May 20, 2015

haf commented May 20, 2015

haf commented May 20, 2015

haf commented May 21, 2015

relentless commented May 21, 2015

haf commented May 27, 2015

relentless commented May 27, 2015

haf commented May 27, 2015