Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add the ability to just disable rules #17

Closed
Giova84 opened this issue Mar 30, 2017 · 5 comments
Closed

Enhancement: add the ability to just disable rules #17

Giova84 opened this issue Mar 30, 2017 · 5 comments

Comments

@Giova84
Copy link

Giova84 commented Mar 30, 2017

Sometimes could be useful to disable some "rules", but actually is only possible by deleting them: in a case of a complex rule, we will have to reinsert again every part of a "formula" which composes the rule.
So would be nice to add a "enable/disable" option for every rule.

@owenca
Copy link
Contributor

owenca commented Apr 9, 2017

I guess the simplest way, from the GUI point of view, is to insert a Disable button between Edit and Remove in the Rules tab. The rules will be grayed out when disabled. What do you think?

@humdingerb
Copy link
Member

Sounds good. The button label should toggle between "Disable" and "Enable" depending on the selected entry.
Maybe even add a "-- disabled" after the rule name in the list, to make it even more obvious.

With 4 buttons below the list, the window gets quite wide. I suggest switching their location with the "Move up/down" buttons, i.e. the Move buttons below, the Add/Edit/etc. vertically arranged to the right of the list.

@owenca
Copy link
Contributor

owenca commented Apr 12, 2017

Is there a way to delete the above links to the intermediate (and squashed) commits? Please use the PR link instead.

@humdingerb
Copy link
Member

Fixed with #18 bd41f3d. Thanks owenca!

@Giova84
Copy link
Author

Giova84 commented Apr 15, 2017

I'd want to say a big thank you to owenca for his good work and improvements on this useful application!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants