Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: haikuports/haikuports
Choose a Base Repository
haikuports/haikuports
11thdimension0/haikuports
29e7e280-0d1c-4bba-98fe-f7cd3ca7500a/haikuports
3541/haikuports
Ace002/haikuports
AetherealLlama/haikuports
Akujiism/haikuports
AlexanderLusth/haikuports
AlwaysLivid/haikuports
Aulene2/haikuports
Barrett17/haikuports
BeOSRefugee/haikuports
Begasus/haikuports
BenjaminAmos/haikuports
CodeforEvolution/haikuports
Crestwave/haikuports
CrisisGamer007/haikuports
Damillora/haikuports
DarkmatterVale/haikuports
DarkmooN420/haikuports
DethroTull/haikuports
DeweyTaylor/haikuports
EppMouse/haikuports
Giova84/haikuports
GodofDragons/haikuports
HelgeCPH/haikuports
IuliaDragoiu/haikuports
JeffroMF/haikuports
Juliush0604/haikuports
KapiX/haikuports
Knezzen/haikuports
Lan72/haikuports
Lesliemanzanerao/haikuports
LordOfDragons/haikuports
Max-Might/haikuports
Nikolay0054/haikuports
Olayemi12/haikuports
Oyami-Srk/haikuports
Paradoxianer/haikuports
Perelandra0x309/haikuports
R167/haikuports
R4H33M/haikuports
Ra-V2/haikuports
RobertoCMCosta/haikuports
Serentty/haikuports
Sudoxo/haikuports
Sylvain78/haikuports
TURX/gci2019-haikuports
Tunas1337/haikuports
TwoFX/haikuports
Val6789/haikuports
Vidrep/haikuports
Vrondir/haikuports
X547/haikuports
adamfowleruk/haikuports
agmsmith/haikuports
ahitech/haikuports
alaviss/haikuports
aligator/haikuports
alphaonex86/haikuports
ambroff/haikuports
andimachovec/haikuports
anirudhjain75/haikuports
annagrram/haikuports
areyoudeveloper/haikuports
arfonzocoward/haikuports
arnavbhatt288/haikuports
bach5000/haikuports
batburger/haikuports
bbjimmy/haikuports
bgroff/haikuports
bitigchi/haikuports
cb88/haikuports
chinopit18cm/haikuports
chris100pher/haikuports
citrix123/haikuports
cnelmortimer/haikuports
dacianf/haikuports
dalmemail/haikuports-gnusocialshell
dash102/haikuports
dasouth1/haikuports
dcatt-haiku/haikuports
devopsdilthar/haikuports
digib0y/haikuports
diversys/haikuports
dominikstrak2001/haikuports
dragonmaus/haikuports
drawkula/haikuports
eddrda/haikuports
ekusaimark/haikuports
emily0618/haikuports
emryslokadottir/haikuports
eniehack/haikuports
enzo1982/haikuports
extrowerk/haikuports
freddietilley/haikuports
fun-alex-alex2006hw/haikuports
gci2017/haikuports
gl00my/haikuports
gouchi/haikuports
hako/haikuports
hannahyp/haikuports
hanya/haikuports
harsh-98/haikuports
hometue/haikuports
humdingerb/haikuports
i80and/haikuports
iam-git/haikuports
ivmai/haikuports
j-koreth/haikuports
jackburton79/haikuports
jamesdtyler/haikuports
jarekpelczar/haikuports
jessicah/haikuports
jmairboeck/haikuports
jrabbit/haikuports-tree
jsteinaker/haikuports
khallebal/haikuports
kikadf/haikuports
koletzky/haikuports
korli/haikuports
ksterker/haikuports
kwyxz/haikuports
lavadew/haikuports
lecast0r/haikuports
linok9757/haikuports
localanu/haikuports
long8a2hgybvn/haikuports
lorglas/haikuports
luka177/haikuports
m199/haikuports
mangoes1024/haikuports
mauritslamers/haikuports
mazbrili/haikuports
mgubi/haikuports
moochris/haikuports
netpositive36/haikuports
nielx/haikuports
nikolaszimmermann/haikuports
nmelnick/haikuports
ocerman/haikuports
oco27/haikuports
ohnx/haikuports
osomat123/haikuports
owenca/haikuports
pgrobelniak/haikuports
phoudoin/haikuports
phw/haikuports
picapi/haikuports
pisculichi/haikuports
pjht/haikuports
probonopd/haikuports
projectgenesis/haikuports
przemub/haikuports
punsith/haikuports
raefaldhia/haikuports
rainlance/haikuports
rbarraud/haikuports
redsPL/haikuports
return/haikuports
richienyhus/haikuports
robcsi/haikuports
roired/haikuports
roptat/haikuports
saswatpp/haikuports
scottmc/haikuports
sfanxiang/haikuports
sikmir/haikuports
skykinetic/haikuports
snetting/haikuports
soakbot/haikuports
stenstorp/haikuports
tangya3158613488/haikuports
taosxx/haikuports
tckmn/haikuports
tehnick/haikuports
th-otto/haikuports
theclue/haikuports
theunrealgeek/haikuports
tidux/haikuports
timfel/haikuports
trungnt2910/haikuports
tsundeoku/haikuports
tts2k/haikuports
unspacyar/haikuports
vanishakesswani/haikuports
vegardw/haikuports
vickykage/haikuports
waddlesplash/haikuports
walkerlala/haikuports
whitone/haikuports
win8linux/haikuports
zooter68/haikuports
zzzzzzzzz/haikuports
Nothing to show
base: c97fdae29c02
head repository: haikuports/haikuports
Choose a Head Repository
haikuports/haikuports
11thdimension0/haikuports
29e7e280-0d1c-4bba-98fe-f7cd3ca7500a/haikuports
3541/haikuports
Ace002/haikuports
AetherealLlama/haikuports
Akujiism/haikuports
AlexanderLusth/haikuports
AlwaysLivid/haikuports
Aulene2/haikuports
Barrett17/haikuports
BeOSRefugee/haikuports
Begasus/haikuports
BenjaminAmos/haikuports
CodeforEvolution/haikuports
Crestwave/haikuports
CrisisGamer007/haikuports
Damillora/haikuports
DarkmatterVale/haikuports
DarkmooN420/haikuports
DethroTull/haikuports
DeweyTaylor/haikuports
EppMouse/haikuports
Giova84/haikuports
GodofDragons/haikuports
HelgeCPH/haikuports
IuliaDragoiu/haikuports
JeffroMF/haikuports
Juliush0604/haikuports
KapiX/haikuports
Knezzen/haikuports
Lan72/haikuports
Lesliemanzanerao/haikuports
LordOfDragons/haikuports
Max-Might/haikuports
Nikolay0054/haikuports
Olayemi12/haikuports
Oyami-Srk/haikuports
Paradoxianer/haikuports
Perelandra0x309/haikuports
R167/haikuports
R4H33M/haikuports
Ra-V2/haikuports
RobertoCMCosta/haikuports
Serentty/haikuports
Sudoxo/haikuports
Sylvain78/haikuports
TURX/gci2019-haikuports
Tunas1337/haikuports
TwoFX/haikuports
Val6789/haikuports
Vidrep/haikuports
Vrondir/haikuports
X547/haikuports
adamfowleruk/haikuports
agmsmith/haikuports
ahitech/haikuports
alaviss/haikuports
aligator/haikuports
alphaonex86/haikuports
ambroff/haikuports
andimachovec/haikuports
anirudhjain75/haikuports
annagrram/haikuports
areyoudeveloper/haikuports
arfonzocoward/haikuports
arnavbhatt288/haikuports
bach5000/haikuports
batburger/haikuports
bbjimmy/haikuports
bgroff/haikuports
bitigchi/haikuports
cb88/haikuports
chinopit18cm/haikuports
chris100pher/haikuports
citrix123/haikuports
cnelmortimer/haikuports
dacianf/haikuports
dalmemail/haikuports-gnusocialshell
dash102/haikuports
dasouth1/haikuports
dcatt-haiku/haikuports
devopsdilthar/haikuports
digib0y/haikuports
diversys/haikuports
dominikstrak2001/haikuports
dragonmaus/haikuports
drawkula/haikuports
eddrda/haikuports
ekusaimark/haikuports
emily0618/haikuports
emryslokadottir/haikuports
eniehack/haikuports
enzo1982/haikuports
extrowerk/haikuports
freddietilley/haikuports
fun-alex-alex2006hw/haikuports
gci2017/haikuports
gl00my/haikuports
gouchi/haikuports
hako/haikuports
hannahyp/haikuports
hanya/haikuports
harsh-98/haikuports
hometue/haikuports
humdingerb/haikuports
i80and/haikuports
iam-git/haikuports
ivmai/haikuports
j-koreth/haikuports
jackburton79/haikuports
jamesdtyler/haikuports
jarekpelczar/haikuports
jessicah/haikuports
jmairboeck/haikuports
jrabbit/haikuports-tree
jsteinaker/haikuports
khallebal/haikuports
kikadf/haikuports
koletzky/haikuports
korli/haikuports
ksterker/haikuports
kwyxz/haikuports
lavadew/haikuports
lecast0r/haikuports
linok9757/haikuports
localanu/haikuports
long8a2hgybvn/haikuports
lorglas/haikuports
luka177/haikuports
m199/haikuports
mangoes1024/haikuports
mauritslamers/haikuports
mazbrili/haikuports
mgubi/haikuports
moochris/haikuports
netpositive36/haikuports
nielx/haikuports
nikolaszimmermann/haikuports
nmelnick/haikuports
ocerman/haikuports
oco27/haikuports
ohnx/haikuports
osomat123/haikuports
owenca/haikuports
pgrobelniak/haikuports
phoudoin/haikuports
phw/haikuports
picapi/haikuports
pisculichi/haikuports
pjht/haikuports
probonopd/haikuports
projectgenesis/haikuports
przemub/haikuports
punsith/haikuports
raefaldhia/haikuports
rainlance/haikuports
rbarraud/haikuports
redsPL/haikuports
return/haikuports
richienyhus/haikuports
robcsi/haikuports
roired/haikuports
roptat/haikuports
saswatpp/haikuports
scottmc/haikuports
sfanxiang/haikuports
sikmir/haikuports
skykinetic/haikuports
snetting/haikuports
soakbot/haikuports
stenstorp/haikuports
tangya3158613488/haikuports
taosxx/haikuports
tckmn/haikuports
tehnick/haikuports
th-otto/haikuports
theclue/haikuports
theunrealgeek/haikuports
tidux/haikuports
timfel/haikuports
trungnt2910/haikuports
tsundeoku/haikuports
tts2k/haikuports
unspacyar/haikuports
vanishakesswani/haikuports
vegardw/haikuports
vickykage/haikuports
waddlesplash/haikuports
walkerlala/haikuports
whitone/haikuports
win8linux/haikuports
zooter68/haikuports
zzzzzzzzz/haikuports
Nothing to show
compare: 5784744bb5d8
  • 1 commit
  • 2 files changed
  • 9 commit comments
  • 1 contributor
Commits on Jun 21, 2016
Some recipes, e.g. mc (Midnight Commander), need libintl.la, but we
were previously dropping all develop/lib/lib*.la files in gettext.
We now ship them and also fix them to make sure they don't become
unusable in case devel:libiconv or devel:libncurses get updated.
On x86 and x86_64 we also fix $developLibDir/libasprintf.la to use
a path to libstdc++.la that does not depend on the revision of the
gcc package.
@@ -13,30 +13,30 @@ massage in various ways the sets of translatable strings, or already \
translated strings. A special GNU Emacs mode also helps interested parties in \
preparing these sets, or bringing them up to date.
"
HOMEPAGE="http://www.gnu.org/software/gettext/"
HOMEPAGE="https://www.gnu.org/software/gettext/"
COPYRIGHT="1998-2016 Free Software Foundation, Inc."
LICENSE="GNU GPL v3"
COPYRIGHT="1998, 2010 Free Software Foundation, Inc."
SOURCE_URI="http://ftp.gnu.org/pub/gnu/gettext/gettext-$portVersion.tar.gz"
CHECKSUM_SHA256="5386d2a40500295783c6a52121adcf42a25519e2d23675950619c9e69558c23f"
REVISION="1"
SOURCE_URI="http://ftpmirror.gnu.org/gettext/gettext-$portVersion.tar.gz"
CHECKSUM_SHA256="ff942af0e438ced4a8b0ea4b0b6e0d6d657157c5e2364de57baa279c1c125c43"
PATCHES="gettext-$portVersion.patchset"

ARCHITECTURES="x86_gcc2 x86 x86_64 arm"
SECONDARY_ARCHITECTURES="x86_gcc2 x86"

PATCHES="gettext-$portVersion.patchset"

PROVIDES="
gettext$secondaryArchSuffix = $portVersion compat >= 0.18
devel:libasprintf$secondaryArchSuffix = 0.0.0 compat >= 0
devel:libgettextlib$secondaryArchSuffix = $portVersion
devel:libgettextlib_0.19.7$secondaryArchSuffix = $portVersion
devel:libgettextpo$secondaryArchSuffix = 0.5.3 compat >= 0
devel:libgettextlib_$portVersion$secondaryArchSuffix
devel:libgettextpo$secondaryArchSuffix = 0.5.4 compat >= 0
devel:libgettextsrc$secondaryArchSuffix = $portVersion
devel:libgettextsrc_0.19.7$secondaryArchSuffix = $portVersion
devel:libintl$secondaryArchSuffix = 8.1.4 compat >= 8
devel:libgettextsrc_$portVersion$secondaryArchSuffix
devel:libintl$secondaryArchSuffix = 8.1.5 compat >= 8
lib:libasprintf$secondaryArchSuffix = 0.0.0 compat >= 0
lib:libgettextlib_0.19.7$secondaryArchSuffix = $portVersion
lib:libgettextpo$secondaryArchSuffix = 0.5.3 compat >= 0
lib:libgettextsrc_0.19.7$secondaryArchSuffix = $portVersion
lib:libgettextlib_$portVersion$secondaryArchSuffix
lib:libgettextpo$secondaryArchSuffix = 0.5.4 compat >= 0
lib:libgettextsrc_$portVersion$secondaryArchSuffix
cmd:autopoint$secondaryArchSuffix = $portVersion compat >= 0
cmd:envsubst$secondaryArchSuffix = $portVersion compat >= 0
cmd:gettext$secondaryArchSuffix = $portVersion compat >= 0
@@ -60,32 +60,51 @@ PROVIDES="
cmd:recode_sr_latin$secondaryArchSuffix = $portVersion compat >= 0
cmd:xgettext$secondaryArchSuffix = $portVersion compat >= 0
"

REQUIRES="
haiku$secondaryArchSuffix
gettext${secondaryArchSuffix}_libintl == $portVersion base
lib:libiconv$secondaryArchSuffix
lib:libncurses$secondaryArchSuffix
devel:libiconv$secondaryArchSuffix
devel:libncurses$secondaryArchSuffix
"
if [ "$effectiveTargetArchitecture" != x86_gcc2 ]; then
REQUIRES="$REQUIRES
lib:libgomp$secondaryArchSuffix
gcc$secondaryArchSuffix
"
fi

SUMMARY_libintl="The gettext internationalization library"
PROVIDES_libintl="
gettext${secondaryArchSuffix}_libintl = $portVersion compat >= 0.18
lib:libintl${secondaryArchSuffix} = 8.1.5 compat >= 8
"
REQUIRES_libintl="
haiku${secondaryArchSuffix}
lib:libiconv${secondaryArchSuffix}
"

BUILD_REQUIRES="
haiku${secondaryArchSuffix}_devel
devel:libiconv$secondaryArchSuffix
devel:libncurses$secondaryArchSuffix
"
BUILD_PREREQUIRES="
haiku${secondaryArchSuffix}_devel
cmd:find
cmd:aclocal
cmd:autoconf
cmd:automake
cmd:autoheader
cmd:gcc$secondaryArchSuffix
cmd:groff
cmd:ld$secondaryArchSuffix
cmd:libtoolize
cmd:libtoolize$secondaryArchSuffix
cmd:make
cmd:makeinfo
cmd:xargs
"

BUILD()
{
find . -name configure | xargs touch
runConfigure ./configure \
--disable-java --without-git \
--disable-rpath --disable-maintainer-mode
@@ -97,12 +116,29 @@ INSTALL()
make install AUTOCONF=: AUTOMAKE=: AUTOHEADER=: ACLOCAL=:

rm $libDir/charset.alias
rm $libDir/lib*.la

prepareInstalledDevelLibs libasprintf libgettextpo libintl
prepareInstalledDevelLib libgettextlib '*.so' '*'
prepareInstalledDevelLib libgettextsrc '*.so' '*'

# The libtool files reference other libraries using paths which
# become invalid if libiconv and/or ncurses6 are upgraded. We need to
# get rid of the versioning of libiconv and ncurses6 in our lib*.la.
local libiconv="$portPackageLinksDir/devel~libiconv$secondaryArchSuffix/$relativeDevelopLibDir"
local libncurses="$portPackageLinksDir/devel~libncurses$secondaryArchSuffix/$relativeDevelopLibDir"
sed -i \
-e "s,/packages/libiconv$secondaryArchSuffix-[^\ /]*/\.self/develop/$relativeLibDir/\(libiconv.la\),$libiconv/\1," \
-e "s,/packages/ncurses6$secondaryArchSuffix-[^\ /]*/\.self/develop/$relativeLibDir/\(libncurses.la\),$libncurses/\1," \
-e "/^dependency_libs=/ s/ -L[^'\ ]*//g" \
$developLibDir/lib*.la

if [ "$effectiveTargetArchitecture" != x86_gcc2 ]; then
local libstdcpp="$portPackageLinksDir/gcc$secondaryArchSuffix"
sed -i \
-e "s,/packages/gcc$secondaryArchSuffix-[^\ /]*/\.self/\(develop/tools/$relativeLibDir/gcc/$effectiveTargetMachineTriple/[^\ /]*/libstdc++.la\),$libstdcpp/\1," \
$developLibDir/libasprintf.la
fi

# libintl package
packageEntries libintl \
$libDir/libintl*
@@ -112,15 +148,3 @@ TEST()
{
make check
}

# ----- libintl package -------------------------------------------------------

SUMMARY_libintl="The gettext internationalization library"
PROVIDES_libintl="
gettext${secondaryArchSuffix}_libintl = $portVersion compat >= 0.18
lib:libintl${secondaryArchSuffix} = 8.1.4 compat >= 8
"
REQUIRES_libintl="
haiku${secondaryArchSuffix}
lib:libiconv${secondaryArchSuffix}
"
@@ -5,7 +5,7 @@ Subject: haiku patch


diff --git a/gettext-tools/src/x-lua.c b/gettext-tools/src/x-lua.c
index 5050838..28c3d91 100644
index 78ac24f..4e3335f 100644
--- a/gettext-tools/src/x-lua.c
+++ b/gettext-tools/src/x-lua.c
@@ -281,9 +281,9 @@ phase2_getc ()
@@ -19,7 +19,7 @@ index 5050838..28c3d91 100644
while (c == '=')
{
esigns++;
@@ -703,11 +703,11 @@ phase3_get (token_ty *tp)
@@ -709,11 +709,11 @@ phase3_get (token_ty *tp)
}
break;

@@ -33,7 +33,7 @@ index 5050838..28c3d91 100644
while (c == '=')
{
esigns++;
@@ -739,10 +739,10 @@ phase3_get (token_ty *tp)
@@ -745,10 +745,10 @@ phase3_get (token_ty *tp)

if (c == ']')
{
@@ -45,7 +45,7 @@ index 5050838..28c3d91 100644
while (c == '=')
{
esigns2++;
@@ -792,7 +792,7 @@ phase3_get (token_ty *tp)
@@ -798,7 +798,7 @@ phase3_get (token_ty *tp)
}
}
break;
@@ -65,7 +65,7 @@ Subject: Fix C99ism in tests.


diff --git a/gettext-tools/gnulib-lib/uniname/uniname.c b/gettext-tools/gnulib-lib/uniname/uniname.c
index 8f9f1b4..7a77a85 100644
index 5da6ced..19ad886 100644
--- a/gettext-tools/gnulib-lib/uniname/uniname.c
+++ b/gettext-tools/gnulib-lib/uniname/uniname.c
@@ -375,6 +375,8 @@ unicode_name_character (const char *name)
@@ -87,10 +87,10 @@ index 8f9f1b4..7a77a85 100644
const char *p1 = buf;
for (;;)
diff --git a/gettext-tools/gnulib-tests/test-quotearg-simple.c b/gettext-tools/gnulib-tests/test-quotearg-simple.c
index b579af7..cf3cb23 100644
index 6bb4b35..8b07c5d 100644
--- a/gettext-tools/gnulib-tests/test-quotearg-simple.c
+++ b/gettext-tools/gnulib-tests/test-quotearg-simple.c
@@ -309,14 +309,16 @@ main (int argc _GL_UNUSED, char *argv[])
@@ -331,14 +331,16 @@ main (int argc _GL_UNUSED, char *argv[])
size_t q_len = 1024;
char *q = malloc (q_len + 1);
char buf[10];
@@ -109,7 +109,7 @@ index b579af7..cf3cb23 100644
z -= s_len + 1;
memcpy (z, str, s_len + 1);

@@ -324,7 +326,7 @@ main (int argc _GL_UNUSED, char *argv[])
@@ -346,7 +348,7 @@ main (int argc _GL_UNUSED, char *argv[])
/* Whether this actually triggers a SEGV depends on the
implementation of memcmp: whether it compares only byte-at-
a-time, and from left to right (no SEGV) or some other way. */

Showing you all comments on commits in this comparison.

@korli

This comment has been minimized.

Copy link
Contributor

korli commented on 5784744 Nov 7, 2016

@fbrosson it's unfortunate to have to add devel:libncurses here, because gettext will depend on ncurses 5 or 6, and will prevent us from using the other ncurses devel package with gettext, because it conflicts.
IMO it would be a good idea to remove the *.la again and fix recipes which would have required them, and remove the dependency on devel:libncurses and devel:libiconv again. mc could avoid depending on libintl for instance, if nls is disabled.

@fbrosson

This comment has been minimized.

Copy link
Member Author

fbrosson commented on 5784744 Nov 7, 2016

No problem. You know this much better than me.
Should I try to make the changes you are suggesting and open a PR for it?
I'm not sure, however, if I'll be able to do that today, so please feel free to do the changes yourself because you'll be faster than me.

@fbrosson

This comment has been minimized.

Copy link
Member Author

fbrosson commented on 5784744 Nov 7, 2016

Shall I create a PR with this:
master...fbrosson:gettext
I did not include any changes in the recipes that would have required the libtool files from gettext.
(If guide me with respect to which recipes I should also edit, I can add the changes to my branch).
Thanks!

@korli

This comment has been minimized.

Copy link
Contributor

korli commented on 5784744 Nov 15, 2016

Sorry for the late reply.
What about devel:libiconv$secondaryArchSuffix and devel:libncurses$secondaryArchSuffix in REQUIRES? I'd remove them anyway.

@fbrosson

This comment has been minimized.

Copy link
Member Author

fbrosson commented on 5784744 Nov 15, 2016

No problem ;-)
That's it. I've just updated my remote branch: master...fbrosson:gettext
Shall I create a PR with it?
(Of course, If you prefer I can push it directly without a PR, but I guess it is better to create a PR.)

@korli

This comment has been minimized.

Copy link
Contributor

korli commented on 5784744 Nov 16, 2016

Please create a PR.

@korli

This comment has been minimized.

Copy link
Contributor

korli commented on 5784744 Nov 16, 2016

A side note: I think it should be >= 0.19. Haikuporter doesn't handle 0.19.xxx compat >= 0.18 correctly, or drop the compat altogether.

@korli

This comment has been minimized.

Copy link
Contributor

korli commented on 5784744 Nov 16, 2016

Ditto >= 0.18 vs >= 0.19.

@fbrosson

This comment has been minimized.

Copy link
Member Author

fbrosson commented on 5784744 Nov 16, 2016

Thanks! PR created: #874.
(I did not test yet, however.)

You can’t perform that action at this time.