New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for QtWebEngine #2512

Open
kenmays opened this Issue Apr 30, 2018 · 20 comments

Comments

7 participants
@kenmays
Copy link
Contributor

kenmays commented Apr 30, 2018

The Qt WebEngine add-on module provides classes and functions for embedding web content in applications and providing Chromium's fast moving web capabilities into Qt.

URL: https://wiki.qt.io/QtWebEngine
Docs: http://doc.qt.io/qt-5/qtwebengine-index.html

@pulkomandy

This comment has been minimized.

Copy link
Member

pulkomandy commented Apr 30, 2018

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented May 17, 2018

@fbrosson

This comment has been minimized.

Copy link
Member

fbrosson commented May 17, 2018

Cool, it looks like you did the most difficult part: port qtwebengine to Haiku! This is great news!

Would you like to try and write a recipe for it?
I'm a bit busy at the moment, otherwise I would have started writing a recipe and opened a PR with a commit ending with Co-authored-by: followed by your users.noreply.github.com GitHub e-mail address :)

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented May 17, 2018

@fbrosson - I've added the Falkon 3.0.1 and Qt WebEngine 5.10.1 recipe and patches to get things started. Everything here should get the ball rolling rather quickly. Asking for further Haikuport dev help to review the recipes to perfection).

@extrowerk

This comment has been minimized.

Copy link
Member

extrowerk commented May 17, 2018

@kenmays : could you please create a pull request with the recipes (one / recipe).
Btw, the qtwebengine patchset looks strange to me, i expected that it requires extensive patching, and you don't even have any Haiku related patch in the patchset. Does it actually builds and works on Haiku?

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented May 17, 2018

Yes, I'm building everything on Haiku. Getting very close but still need a lot of free time. Backing everything up for now. Will work on it more as my time permits. A few dev packages required proper setup for qmake detection (from a clean build system).

NOTE: May work on Haikuports build system without issue.

@extrowerk

This comment has been minimized.

Copy link
Member

extrowerk commented May 18, 2018

Does xcursor and xrandr a hard dependency?

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented May 18, 2018

No. Removed them. We'll need to fix a few of the mentioned optional dependencies.

@extrowerk

This comment has been minimized.

Copy link
Member

extrowerk commented May 19, 2018

@kenmays : Please, create a recipe, or post your actual patchset, or post at least one screenshot about QtWebEngine on Haiku, because your patchset doesn't apply cleanly and contains no actual Haiku supporting code.

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented May 19, 2018

@extrowerk - I'll post it soon and fix the patchset (it was just to provide others with some patches for their own use). Mentioned earlier I'm doing a complete walkthrough to first fix dependency packages before anyone else goes down this rabbit hole. (The main goal task was to just create the Qt WebEngine recipe.)

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented May 22, 2018

Almost perfected my optional dependencies on Haiku.

@extrowerk

This comment has been minimized.

Copy link
Member

extrowerk commented May 22, 2018

Mate... They are mostly optional dependencies.
Your source tree configured and ready to rock, just type make to let the fun begin ;)
Have you tried it already?

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented May 23, 2018

Yes. Tested again with qt-webengine v5.11.0 yesterday. Had to fix my setup after the update to GCC 7. Built and tested ICU 61.1. Time to dive back in and spin the wheel... (patchwork, etc.)

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented Jun 1, 2018

See #2632
Provided initial recipes for Falkon and Qt WebEngine for future work. Closing ticket for now.
Working on WebPositive and Webkit for R1 beta.

@kenmays kenmays closed this Jun 1, 2018

@extrowerk

This comment has been minimized.

Copy link
Member

extrowerk commented Jun 5, 2018

Post your patches.

@extrowerk

This comment has been minimized.

Copy link
Member

extrowerk commented Sep 8, 2018

@kenmays : how is this relevant? The whole web is a testcase.

@extrowerk

This comment has been minimized.

Copy link
Member

extrowerk commented Sep 9, 2018

@kenmays : can you please remove the screenshots too? Thanks.

@KapiX

This comment has been minimized.

Copy link
Member

KapiX commented Oct 18, 2018

Reposting from the PR so it won't be lost: https://gist.github.com/KapiX/8502596ef66813195cf8d2bec7393cd7 - with this patch QtWebEngine can be built, but will crash immediately.

@kenmays

This comment has been minimized.

Copy link
Contributor

kenmays commented Oct 18, 2018

I've posted qtwebengine-5.11.2 here for review and testing:
https://github.com/kenmays/haikuports/tree/qtwebengine-5.11.2/dev-qt/qtwebengine

It is NOT finished. I'm working on it as my time permits.

@cb88

This comment has been minimized.

Copy link
Contributor

cb88 commented Oct 27, 2018

Also a dependency for AMD's CodeXL profiler which is MIT licensed and might come in really handy for application developers... https://github.com/GPUOpen-Tools/CodeXL/blob/master/BUILD.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment