Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU: Bump to ICU v61.1 #2598

Closed
kenmays opened this issue May 23, 2018 · 7 comments
Closed

ICU: Bump to ICU v61.1 #2598

kenmays opened this issue May 23, 2018 · 7 comments

Comments

@kenmays
Copy link
Contributor

@kenmays kenmays commented May 23, 2018

ICU 61 provides full support for the recent Unicode 10.0 release with many new characters and many property improvements. Unicode 10.0 adds 8,518 characters, for a total of 136,690 characters. These additions include 4 new scripts, for a total of 139 scripts, as well as 56 new emoji characters. Locale data is updated to CLDR 33 locale data and adds Google double-conversion library for formatting doubles. This is the library used in V8 and a number of other projects for converting doubles to decimals.

Homepage: http://site.icu-project.org/
Src: http://download.icu-project.org/files/icu4c/61.1/icu4c-61_1-src.tgz

Successfully Tested: ICU 61.1 on Haiku x86_64 hrev51971
icu-61.1-testing_cocobean.txt

Recipe/Patches:
icu-61.1-haiku.zip

@kenmays kenmays changed the title ICU: Bump to ICU v60.2 ICU: Bump to ICU v61.1 May 23, 2018
@korli

This comment has been minimized.

Copy link
Contributor

@korli korli commented May 23, 2018

What about gcc2?

@kenmays

This comment has been minimized.

Copy link
Contributor Author

@kenmays kenmays commented May 23, 2018

[All tests passed successfully...]
Elapsed time: 00:00:50.659
Successfully Tested: ICU 61.1 on Haiku x86 hrev51976 (GCC7)

GCC2: I cleaned up the gcc2 patch for ICU 61.1. Can complete later.
icu-61.1.gcc2.patchset.txt

@kenmays

This comment has been minimized.

Copy link
Contributor Author

@kenmays kenmays commented May 29, 2018

Ticket: https://dev.haiku-os.org/ticket/14183 (regressions?)
Ref: #2046 - Referenced older ticket by scottmc.
@korli - May need help to finish porting ICU 61.1 using x86_gcc2.

@kenmays kenmays closed this May 29, 2018
@kenmays kenmays reopened this Jun 4, 2018
@extrowerk extrowerk mentioned this issue Jul 23, 2018
@extrowerk

This comment has been minimized.

Copy link
Member

@extrowerk extrowerk commented Jul 23, 2018

@kenmays : please use pull requests for your work, and do not manually edit the patch files.
Are your recipes tested with haikuporter?

My PR superseeds your patches and recipe, but it would be nice if you would use the infrastructure, as it allows us to give comments, ideas and check your work easily.

@extrowerk

This comment has been minimized.

Copy link
Member

@extrowerk extrowerk commented Jul 23, 2018

Your gcc2 patchset summary references files, wich aren't patched in your patchset, that's inconsistent and not acceptable.

@fbrosson

This comment has been minimized.

Copy link
Member

@fbrosson fbrosson commented Jul 23, 2018

@kenmays, I can see that you have some activity on GitHub, and even a repo, but it looks like you don't craate many PRs.. You should really not hesitate to do so! We'd love to see you contributing to HaikuPorts with pull requests :)

BTW, in case you are not yet comfortable with Git you can read some tutorials and/or ask for help at any time.

@kenmays

This comment has been minimized.

Copy link
Contributor Author

@kenmays kenmays commented Jul 24, 2018

@extrowerk - Amazing work on bumping ICU. Closing this one!

@kenmays kenmays closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.