Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for FTP #1240

Merged
merged 4 commits into from Mar 23, 2017
Merged

Patch for FTP #1240

merged 4 commits into from Mar 23, 2017

Conversation

@walkerlala
Copy link
Contributor

walkerlala commented Mar 23, 2017

No description provided.

ARCHITECTURES="x86_64 x86 x86_gcc2"

PROVIDES="
ntftp = $portVersion

This comment has been minimized.

Copy link
@korli

korli Mar 23, 2017

Contributor

ntftp => tnftp

make install
}
LICENSE="BSD (2-clause)"
COPYRIGHT="2001-20015 The NetBSD Foundation, Inc. All rights reserved."

This comment has been minimized.

Copy link
@korli

korli Mar 23, 2017

Contributor

Please move these two lines after HOMEPAGE.

This comment has been minimized.

Copy link
@korli

korli Mar 23, 2017

Contributor

sorry before HOMEPAGE

Copy link
Member

humdingerb left a comment

Also: PATCHES under SOURCE_DIR, no empty lines between PROVIDES and REQUIRES.
no empty lines between BUILD_REQUIRES and BUILD_PREREQUIRES

@@ -1,14 +1,16 @@
SUMMARY="NetBSD luke FTP client"
DESCRIPTION="NetBSD FTP client with several advanced features"

This comment has been minimized.

Copy link
@humdingerb

humdingerb Mar 23, 2017

Member

"You could elaborate the DESCRIPTION with what's at http://freecode.com/projects/tnftp/:

tnftp (formerly known as lukemftp) is a port of the NetBSD FTP client. It offers many enhancements over the traditional BSD FTP client, including

  • command-line editing,
  • command-line fetches of FTP and HTTP URLs (including via proxies),
  • command-line uploads of FTP URLs,"

... etc

Mind the 80 char limit (compare to other recipes)

@@ -1,14 +1,16 @@
SUMMARY="NetBSD luke FTP client"
DESCRIPTION="NetBSD FTP client with several advanced features"
HOMEPAGE="ftp://ftp.netbsd.org/pub/NetBSD/misc/tnftp/"
LICENSE="BSD (2-clause)"
COPYRIGHT="2001-20015 The NetBSD Foundation, Inc. All rights reserved."

This comment has been minimized.

Copy link
@humdingerb
@@ -1,14 +1,16 @@
SUMMARY="NetBSD luke FTP client"
DESCRIPTION="NetBSD FTP client with several advanced features"
HOMEPAGE="ftp://ftp.netbsd.org/pub/NetBSD/misc/tnftp/"
LICENSE="BSD (2-clause)"
COPYRIGHT="2001-20015 The NetBSD Foundation, Inc. All rights reserved."
SOURCE_URI="http://ftp.NetBSD.org/pub/NetBSD/misc/tnftp/tnftp-20151004.tar.gz"
REVISION="1"
CHECKSUM_SHA256="c94a8a49d3f4aec1965feea831d4d5bf6f90c65fd8381ee0863d11a5029a43a0"

This comment has been minimized.

Copy link
@humdingerb

humdingerb Mar 23, 2017

Member

Ordering again

@@ -1,14 +1,16 @@
SUMMARY="NetBSD luke FTP client"
DESCRIPTION="NetBSD FTP client with several advanced features"
HOMEPAGE="ftp://ftp.netbsd.org/pub/NetBSD/misc/tnftp/"
LICENSE="BSD (2-clause)"
COPYRIGHT="2001-20015 The NetBSD Foundation, Inc. All rights reserved."
SOURCE_URI="http://ftp.NetBSD.org/pub/NetBSD/misc/tnftp/tnftp-20151004.tar.gz"
REVISION="1"
CHECKSUM_SHA256="c94a8a49d3f4aec1965feea831d4d5bf6f90c65fd8381ee0863d11a5029a43a0"

ARCHITECTURES="x86_64 x86 x86_gcc2"

This comment has been minimized.

Copy link
@humdingerb

humdingerb Mar 23, 2017

Member

ordering: x86_gcc2 x86 x86_64

This comment has been minimized.

Copy link
@korli

korli Mar 23, 2017

Contributor

@humdingerb sorry I didn't see your additional comments before merging.

@korli korli merged commit ea6c20b into haikuports:master Mar 23, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
CodeforEvolution pushed a commit to CodeforEvolution/haikuports that referenced this pull request May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.