Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: Enable thread-local storage in clang #1362

Merged
merged 1 commit into from Jun 1, 2017

Conversation

@return
Copy link
Contributor

return commented May 23, 2017

This commit solves issue #789 by enabling TLS support in clang by default. This is known to work on x86_64 by passing the -fPIC flag, but I haven't tested it on x86 yet.

@korli

This comment has been minimized.

Copy link
Contributor

korli commented May 23, 2017

You should probably disable PIE by default on x86_64 then.

@return

This comment has been minimized.

Copy link
Contributor Author

return commented May 30, 2017

@korli I've tried disabling PIE/PIC via -DLLVM_ENABLE_PIC=NO, but this fails to link a non-pie object. Is it related to this ticket: https://dev.haiku-os.org/ticket/13292 with gcc5?

@korli

This comment has been minimized.

Copy link
Contributor

korli commented May 30, 2017

@return return force-pushed the return:clang-tls-fix branch from 431108e to 08d7ec8 May 31, 2017
@return

This comment has been minimized.

Copy link
Contributor Author

return commented May 31, 2017

@korli PIE on x86_64 is now disabled by default.

@korli

This comment has been minimized.

Copy link
Contributor

korli commented Jun 1, 2017

@return incorrect, default PIE was only enabled on x86_64. it's now enabled for x86.

@return return force-pushed the return:clang-tls-fix branch from 08d7ec8 to efed7ad Jun 1, 2017
disable PIE by default on all archs and bump revision.
@return return force-pushed the return:clang-tls-fix branch from efed7ad to b631684 Jun 1, 2017
@korli korli merged commit 1819d52 into haikuports:master Jun 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@return return deleted the return:clang-tls-fix branch Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.