drawpile: new recipe

[hako]

Drawpile works on Haiku, still a wip.

[extrowerk]

Remove if unneeded.

[extrowerk]

Remove the space at the beginning.

[extrowerk]

Add a space before that \

[extrowerk]

Use https

[extrowerk]

sort them please

[extrowerk]

sort them too

[extrowerk]

if it is cmake based, then it shouldn't need qmake. please check it, and remove it if unneeded.

[extrowerk]

Remove the trailing whitespace

[extrowerk]

Nice job nevertheless!

[fbrosson]

Cosmetic edits

[fbrosson]

-HOMEPAGE="https://drawpile.net"
+HOMEPAGE="https://drawpile.net/"

(if you are OK with this tiny change :)
Thanks!

[fbrosson]

 CHECKSUM_SHA256="0ff79e9f95ca02ff016eed3118a83ca62e80a1ca93fe11e3fb8ecd22c1fe37a9"
+SOURCE_FILENAME="Drawpile-$portVersion.tar.gz"
 SOURCE_DIR="Drawpile-$portVersion"
+
 ARCHITECTURES="!x86_gcc2 ?x86 x86_64"

Links:

• HaikuPorter-Guidelines#archive-name
• HaikuPorter-Guidelines#ordering

[fbrosson]

 	"
-
 REQUIRES="

(We like to have blank lines at some places, but not between PROVIDES and REQUIRES :)

[fbrosson]

 	"
-
 BUILD_PREREQUIRES="

(We like to have blank lines at some places, but not between BUILD_REQUIRES and BUILD_PREREQUIRES :)

[fbrosson]

Some editors don't put a LF (line-feed) at the end of the last line, but vi(m) does not like this very much, so if you could add one here, it would be cool :)

(vi(m) shows a [Incomplete last line] warning when we open a file that is missing the LF character at its last line.)

You can "fix" this "issue" with:

echo wq | ed drawpile-2.0.10.recipe

Thanks!

[fbrosson]

Thanks @hako for the update!

Although BUILD seems OK, INSTALL is failing:

[100%] Linking CXX executable ../../bin/drawpile-srv
[100%] Built target drawpile-srv
Collecting files to be packaged ...
cp: cannot stat 'bin/drawpile': No such file or directory
Warning: Command '['bash', '-c', '. /wrapper-script']' returned non-zero exit status 1
Error: Build has failed - stopping.

(I guess it'll be easy to fix, but can't investigate right now, so I'm marking the PR with a "Request changes" so that it won't be merged before we fix the recipe.)

[hako]

Can confirm, I've changed the build path and it built the package successfully.

[fbrosson]

Thanks @hako for the update! The app builds fine on both x86_64 and x86_gcc2 (using x86 secondary arch) and is working fine on x86_64.

haikuporter --test drawpile is not working because we're not passing -DTESTS=on to cmake.

To fix this, we can either:

1. append a -DTESTS=on to the cmake call in BUILD and, in TEST, replace make test by make -C build test
2. or change TEST to:

TEST()
{
	cd build
	cmake .. -DCMAKE_EXE_LINKER_FLAGS=-lnetwork -DTESTS=on
	make $jobArgs
	make test
}

3. Of course, we can keep BUILD as it is right now and completely drop TEST.

I think scenario 1 would be nice. What do you think? Any other opinions?

[hako]

I modified and built the script with scenario 1 instead.

[fbrosson]

Thanks @hako for the update.
I was going to approve and merge the PR but then realized I had forgotten to check the REQUIRES.
It looks like Drawpile does not directly require 2 libs: libGL and libz:

~> objdump -x /system/apps/Drawpile/* | grep NEEDED | sort -iu | grep -Evw 'libroot|libnetwork'
  NEEDED               libgcc_s.so.1
  NEEDED               libgif.so.7
  NEEDED               libKF5Archive.so.5
  NEEDED               libminiupnpc.so.17
  NEEDED               libQt5Core.so.5
  NEEDED               libQt5Gui.so.5
  NEEDED               libQt5Multimedia.so.5
  NEEDED               libQt5Network.so.5
  NEEDED               libQt5Sql.so.5
  NEEDED               libQt5Svg.so.5
  NEEDED               libQt5Widgets.so.5
  NEEDED               libsodium.so.23
  NEEDED               libstdc++.so.6

Although the names are not case-sensitive I think it might be nice to make the caps match, and to explicitly add a few lib:libQt5* which are not yet mentioned:

 REQUIRES="
 	haiku$secondaryArchSuffix
 	lib:libgif$secondaryArchSuffix
-	lib:libGL$secondaryArchSuffix
-	lib:libkf5archive$secondaryArchSuffix
+	lib:libKF5Archive$secondaryArchSuffix
 	lib:libminiupnpc$secondaryArchSuffix
 	lib:libQt5Core$secondaryArchSuffix
 	lib:libQt5Gui$secondaryArchSuffix
+	lib:libQt5Multimedia$secondaryArchSuffix
 	lib:libQt5Network$secondaryArchSuffix
+	lib:libQt5Sql$secondaryArchSuffix
+	lib:libQt5Svg$secondaryArchSuffix
+	lib:libQt5Widgets$secondaryArchSuffix
 	lib:libsodium$secondaryArchSuffix
-	lib:libz$secondaryArchSuffix
 	"

I'm checking this right now, with haikuporter -S drawpile.

BTW, don't worry about libgcc_s.so.1 and libstdc++.so.6. haikuporter is not complaining about them, so my guess is that we don't need to mention lib:libgcc_s$secondaryArchSuffix and lib:libstdc++$secondaryArchSuffix.

[fbrosson]

👍

The comments have been addressed.