Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSH global-writeable settings with "keep-old" flag #329

Merged
merged 1 commit into from Jun 7, 2016

Conversation

@fbrosson
Copy link
Member

fbrosson commented Jun 7, 2016

I updated my Haiku install, and then tried to log in through sftp. It worked before, but not anymore. I was able to log in through SSH, but not with SFTP.

I located the problem, it is the keep-old flag of the /boot/system/settings/ssh/sshd_config file.

It had the following line:
Subsystem sftp /packages/openssh-6.6p1-1/.self/lib/openssh/sftp-server
but the correct path is:
Subsystem sftp /packages/openssh-7.1p1-1/.self/lib/openssh/sftp-server

We should somehow update this file after each openssh update.

@pulkomandy
Copy link
Member

pulkomandy commented Feb 14, 2016

A better fix would be to not use a package-specific path there and point to /system instead?

Also add a post-install script, fix_openssh_config_paths.sh, which
makes the required changes to both ssh_config and sshd_config in
/boot/system/settings/ssh/ if needed. Original files are saved with
a .bak suffix. Moreover, default config files are also available in
/system/data/openssh/ as ssh_config.default and sshd_config.default.
@fbrosson
Copy link
Member

fbrosson commented Jun 7, 2016

I've just converted this issue into a PR by attaching a commit that fixes the bug.

@fbrosson fbrosson merged commit 8a585d3 into haikuports:master Jun 7, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fbrosson fbrosson deleted the fbrosson:openssh branch Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.