Skip to content

/ haikuports

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GnuCOBOL, new recipe #3786

Closed
wants to merge 9 commits into from
+68 −0
Closed

GnuCOBOL, new recipe #3786

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ad6148
Create .gitkeep
Knezzen Apr 22, 2019
17aa337
Create gnucobol-3.0~rc1.recipe
Knezzen Apr 22, 2019
8af4d41
Delete .gitkeep
Knezzen Apr 22, 2019
c217901
Update gnucobol-3.0~rc1.recipe
Knezzen Apr 22, 2019
eb2ce7c
Update gnucobol-3.0~rc1.recipe
Knezzen Apr 22, 2019
ddaec89
Update gnucobol-3.0~rc1.recipe
Knezzen Apr 22, 2019
75ccf9f
Update gnucobol-3.0~rc1.recipe
Knezzen Apr 22, 2019
e45fa0e
Update gnucobol-3.0~rc1.recipe
Knezzen Apr 22, 2019
7b01282
Update gnucobol-3.0~rc1.recipe
Knezzen Apr 23, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

68 dev-lang/cobol/gnucobol-3.0~rc1.recipe
View file
Open in desktop
@@ -0,0 +1,68 @@
SUMMARY="A free COBOL compiler"
DESCRIPTION="GnuCOBOL (formerly OpenCOBOL) is a free COBOL compiler."
HOMEPAGE="https://sourceforge.net/projects/open-cobol/"
This conversation was marked as resolved by Knezzen

This comment has been minimized.

Sign in to view
Copy link
@extrowerk

extrowerk Apr 22, 2019

Member

Ordering: https://github.com/haikuports/haikuports/wiki/HaikuPorter-Guidelines#ordering
COPYRIGHT="2001-2019 Free Software Foundation, Inc"

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Apr 23, 2019

Contributor

Missing authors (you can see them if you run cobc --version in Terminal)
LICENSE="GNU GPL v3, GNU LGPL v3, "

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Jun 22, 2019

Contributor

Suggesting (travis check fail here):

-LICENSE="GNU GPL v3, GNU LGPL v3, "
+LICENSE="GNU GPL v3
+	GNU LGPL v3
+	GNU FDL v1.3" (this needs to be copied from the source to directory "licences"
REVISION="1"
SOURCE_URI="https://downloads.sf.net/open-cobol/gnu-cobol/gnucobol-3.0-rc1.tar.gz"
CHECKSUM_SHA256="e55aeea6b1f77e763b4cd4b520c78eb06da7671b4dcc76463fd0237dbf2e4816"
SOURCE_DIR="gnucobol-3.0-rc1"

ARCHITECTURES="x86_64"

This comment has been minimized.

Sign in to view
Copy link
@extrowerk

extrowerk Apr 22, 2019

Member

Could you please test it on x86? You will have to add some $secondaryArchSuffix-es here and there.

This comment has been minimized.

Sign in to view
Copy link
@Knezzen

Knezzen Apr 23, 2019

Author

I don't have a x86 Haiku machine at the moment, went x86_64 on both my Haiku machines.
I could test it in a VM though.

PROVIDES="
gnucobol = $portVersion
cmd:cob_config

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Apr 23, 2019

Contributor

This should go into the devel package I think?
cmd:cobc = $portVersion
cmd:cobcrun = $portVersion
lib:libcob

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Apr 23, 2019

Contributor

soname is 4.0.0 so it has to be added here (or use libVersionCompat)
It also need a devel:libcob to install the static lib (strange that haikuporter -S doesn't complain about it)
"
REQUIRES="
haiku
lib:libdb
lib:libgmp
lib:libidn2

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Apr 23, 2019

Contributor

Not needed:

-	lib:libidn2
lib:libintl
lib:libltdl
lib:libncurses
"

BUILD_REQUIRES="
This conversation was marked as resolved by Knezzen

This comment has been minimized.

Sign in to view
Copy link
@extrowerk

extrowerk Apr 22, 2019

Member

Please add a newline before this
haiku_devel
devel:libdb
devel:libgmp
devel:libidn2

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Apr 23, 2019

Contributor

Not needed:

-	devel:libidn2
devel:libintl
devel:libltdl
devel:libncurses
"
BUILD_PREREQUIRES="
cmd:aclocal
cmd:autoconf
cmd:bison

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Apr 23, 2019

Contributor 
+	cmd:awk
cmd:flex
cmd:gcc
cmd:make
cmd:m4
cmd:perl

This comment has been minimized.

Sign in to view
Copy link
@Begasus

Begasus Apr 23, 2019

Contributor

Not needed here:

-	cmd:m4
-	cmd:perl
cmd:pkg_config
"

BUILD()
This conversation was marked as resolved by Knezzen

This comment has been minimized.

Sign in to view
Copy link
@extrowerk

extrowerk Apr 22, 2019

Member

Please add a newline before this
{
autoreconf -vfi
runConfigure ./configure
make $jobArgs
}

INSTALL()
This conversation was marked as resolved by Knezzen

This comment has been minimized.

Sign in to view
Copy link
@extrowerk

extrowerk Apr 22, 2019

Member

Please add a newline before this
{
make install
prepareInstalledDevelLib libcob cobconfig
rm $developLibDir/*.la
fixPkgconfig

# devel package
packageEntries devel \
$developDir
}
This conversation was marked as resolved by Knezzen

This comment has been minimized.

Sign in to view
Copy link
@extrowerk

extrowerk Apr 22, 2019

Member

Could you please check if it comes with some tests? If so, please add a TEST() section too. Do not forget about the newline before the TEST()

This comment has been minimized.

Sign in to view
Copy link
@Knezzen

Knezzen Apr 22, 2019

Author

No tests that I know of. Updated the rest as you commented.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.