Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harfbuzz: bump to 1.2.7, add TEST() with "make check". (WIP) #632

Merged
merged 1 commit into from Jun 19, 2016

Conversation

@fbrosson
Copy link
Member

fbrosson commented Jun 10, 2016

  • Bump to version 1.2.7, add TEST() with make check.
  • Add patch for 3 tests that would otherwise fail or be skipped.
  • Add cmd:{python,which} to BUILD_PREREQ, as make check needs them.
  • Drop explicit call to autoreconf as it is no longer needed.
@waddlesplash
Copy link
Member

waddlesplash commented Jun 19, 2016

Looks good to me. Merge?

@fbrosson
Copy link
Member Author

fbrosson commented Jun 19, 2016

Some tests were failling, but I figured out how to fix them ;-)
Now all tests pass, except one, src/check-libstdc++.sh, which yelds: check-libstdc++.sh: 'ldd' not found; skipping test
I'd like to patch that script to make it use objdump -x and grep NEEDED. Would it be OK to merge a recipe with such a patch?

Regarding the REQUIRES_devel, I added devel:libglib_2.0 and devel:libgraphite2 to it, based on the Requires.private of harfbuzz.pc: glib-2.0 >= 2.16 graphite2. Am I right for the REQUIRES_devel about that? Thanks!

@waddlesplash
Copy link
Member

waddlesplash commented Jun 19, 2016

I'd like to patch that script to make it use objdump -x and grep NEEDED. Would it be OK to merge a recipe with such a patch?

Eh, don't bother.

Am I right for the REQUIRES_devel about that? Thanks!

That sounds correct, I suppose.

@fbrosson
Copy link
Member Author

fbrosson commented Jun 19, 2016

OK, thanks for your reply.
BTW, would it be worth adding to REQUIRES_devel all the devel:lib* we have in BUILD_REQUIRES?

Switching back to x86_gcc2, when I test for x86 secondary arch, src/test-ot-tag fails and sends the following line to the log:

runtime_loader: Cannot open file libharfbuzz.so.0: No such file or directory

I noticed that launching src/.libs/test-ot-tag from the chrooted environment yelds the same error, but I can't find how to change the wrapper script, src/test-ot-tag, to fix this error.
Shall I ignore this error?
All tests are OK on x86 and x86_64 (with the exception of the skipped test), so I guess it might be OK to merge (once I remove the "WIP" tag, of course).
Shall I try to build mupdf 1.7 (and/or 1.9a) against harfbuzz 1.2.7 before I merge this PR?

@korli
Copy link
Contributor

korli commented Jun 19, 2016

"libraries from Requires.private will only be included when static linking."
Thus they shouldn't be added to REQUIRES_devel.

* Bump to version 1.2.7, add TEST() with "make check".
* Add patch for 3 tests that would otherwise fail or be skipped.
* Add cmd:{python,which} to BUILD_PREREQ, as "make check" needs them.
* Drop explicit call to autoreconf as it is no longer needed.
@fbrosson
Copy link
Member Author

fbrosson commented Jun 19, 2016

OK, thanks. I've just fixed REQUIRES_devel.

@waddlesplash waddlesplash merged commit c5870ba into haikuports:master Jun 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@waddlesplash
Copy link
Member

waddlesplash commented Jun 19, 2016

@fbrosson btw: most HaikuPorts developers also hang out in the #haiku channel on Freenode, if you'd care to join us.

@fbrosson
Copy link
Member Author

fbrosson commented Jun 19, 2016

Yep, I know. But I read, from time to time, the logs that echelog.com creates with what goes to the #haiku channel. I find it more confortable, since I'm always in read-only mode ;-)

@fbrosson fbrosson deleted the fbrosson:harfbuzz branch Jun 19, 2016
@waddlesplash
Copy link
Member

waddlesplash commented Jun 19, 2016

Ah yes, but what's the fun in that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.