Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uplibebml: fix libebml.la for all archies other than x86_gcc2. #667
Conversation
fbrosson
changed the title
* On all architectures other than x86_gcc2 the generated definition of dependency_libs in libebml.la includes a path to libstdc++.la that hard-codes the full version of the gcc package being used to build libebml. Keeping that path unchanged would result in a hidden dependency of libebml_devel on a specific revision of the gcc pkg. So fix that path using a package-links dir that starts with e.g. /packages/libebml_x86_devel-*/gcc_x86/develop/tools/x86/lib/gcc/... * Add gcc$secondaryArchSuffix to REQUIRES_devel when building for an architecture other than x86_gcc2 because libebml.la needs it. * Add TEST() with "make check".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fbrosson commentedJun 24, 2016
•
edited
libebml.laincludes a path tolibstdc++.lathat hard-codes the full version of the gcc package being used to build libebml. Keeping that path unchanged would result in a hidden dependency of libebml_devel on a specific revision of the gcc package. So fix that path using a package-links dir that starts with e.g./packages/libebml_x86_devel-*/gcc_x86/develop/tools/x86/lib/gcc/...gcc$secondaryArchSuffixto REQUIRES_devel when building for an architecture other than x86_gcc2 becauselibebml.laneeds it.make check.